gasket icon indicating copy to clipboard operation
gasket copied to clipboard

Published 20 hours ago • verified publisher icon godaddy

Remove duplicate next link in README

Open Zeedinstein opened this issue 2 years ago • 5 comments

Noticed a duplicate link in the readme that was unnecessary.

Zeedinstein avatar Aug 11 '22 12:08 Zeedinstein

Is this auto-generated code, though? I wonder how it got generated as a duplicate.

jpage-godaddy avatar Aug 11 '22 15:08 jpage-godaddy

Sure I'll have a look at that

Zeedinstein avatar Aug 12 '22 08:08 Zeedinstein

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

sonarqubecloud[bot] avatar Aug 12 '22 08:08 sonarqubecloud[bot]

@jpage-godaddy This should now only generate the one next link. Which I don't see a problem with. Unless having 2 links was done on purpose for express and fastify? But I still don't see a reason to have 2 next links.

Zeedinstein avatar Aug 12 '22 08:08 Zeedinstein

@jpage-godaddy This should now only generate the one next link. Which I don't see a problem with. Unless having 2 links was done on purpose for express and fastify? But I still don't see a reason to have 2 next links.

Hm, yeah I didn't notice until now that they had different parents, so they're not really duplicated. When the lifecycle diagram is generated, those two next entries are both used. It sounds like the script that generates the markdown documentation is the real issue; that needs to do the de-duplication. Finding where that bug in the documentation generation code is would be key here.

jpage-godaddy avatar Aug 15 '22 16:08 jpage-godaddy

Resolved in https://github.com/godaddy/gasket/pull/472

agerard-godaddy avatar Oct 10 '22 22:10 agerard-godaddy