compose-color-picker icon indicating copy to clipboard operation
compose-color-picker copied to clipboard

Published 20 hours ago • verified publisher icon godaddy

Add the ability to change color programmatically

Open thadcodes opened this issue 3 years ago • 9 comments
trafficstars

This should resolve issue #18, at least for the HarmonyColorPicker. It looks like the Classic one should already support programmatically updating itself.

thadcodes avatar Sep 20 '22 15:09 thadcodes

Hi @thadcodes, sorry for the delay. I will look at those changes, but they look outstanding. Thanks.

ffgiraldez avatar Sep 23 '22 10:09 ffgiraldez

@riggaroo Updated based on your feedback. Will open the brightness bar PR as soon as this is merged

thadcodes avatar Sep 26 '22 14:09 thadcodes

Sorry @ffgiraldez I pushed my changes to the wrong branch that's why you are not seeing them, I'll have them up on the right branch.

I can see the argument on the Color Picker that programmatically updates. I actually wrote that when I was going to have two versions before just deprecating the old one. I am fine doing that as the comment should be in the deprecation warning now that they are not both correct versions

thadcodes avatar Sep 30 '22 14:09 thadcodes

ok @ffgiraldez updated, sorry about the wasted review cycle. 🤦‍♂️

thadcodes avatar Sep 30 '22 14:09 thadcodes

You probably will punch me, but please, could you update the example in the README to match real param names?

ffgiraldez avatar Sep 30 '22 14:09 ffgiraldez

You probably will punch me, but please, could you update the example in the README to match real param names?

@ffgiraldez LOL no not at all, that's what I get for assuming IntelliJ would rename it here too and not checking. Fixed and pushed. Lucky you found that because I also had an error in the example that wasn't just renaming

thadcodes avatar Sep 30 '22 14:09 thadcodes

@thadcodes LGTM now, I need to check why the signing is failing on CI😓

ffgiraldez avatar Sep 30 '22 14:09 ffgiraldez

@thadcodes Thanks - that is fixed! 🎉 One last request - can you update ClassicColorPickerScreen for the desktop build as that is using the deprecated version?

riggaroo avatar Oct 09 '22 09:10 riggaroo

@thadcodes Thanks - that is fixed! 🎉 One last request - can you update ClassicColorPickerScreen for the desktop build as that is using the deprecated version? @riggaroo sorry for the delayed response. This latest update should address your concerns

thadcodes avatar Oct 19 '22 20:10 thadcodes

Waiting for #49 to merge this. Sorry for all of this @thadcodes

ffgiraldez avatar Oct 24 '22 11:10 ffgiraldez