activerecord-delay_touching icon indicating copy to clipboard operation
activerecord-delay_touching copied to clipboard

Failing test for polymorphic association touches while before_save raises

Open lcoq opened this issue 9 years ago • 2 comments

The test does not fail but starts an infinite loop which updates the persons updated_at where id is NULL

lcoq avatar Jun 02 '15 11:06 lcoq

Encouter this one too. Would you accept a PR trying to fix this bug ?

bobbus avatar Jun 18 '15 11:06 bobbus

HI @Icoq and @bobbus. Apologies for not responding sooner. We absolutely do accept PRs fixing issues. My only feedback here is that the Spec should also be finite, meaning it can check something like expect(something).to receive(:some_method).exactly(n).times. I'm sure the spec included here is just to demonstrate that an infinite loop is occurring, but wanted to call this out just to make sure we're on the same page. Appreciate any help on tackling this!

mtuckergh avatar Jun 18 '15 15:06 mtuckergh