primer icon indicating copy to clipboard operation
primer copied to clipboard

Add auto-height Javascript for 'expand' mobile drop-downs.

Open chriswallace opened this issue 8 years ago • 2 comments

@fjarrett @jonathanbardo As I go through and fix this issue across multiple themes, I'm realizing there's no great CSS solution for matching the height of the expand button with that of the mobile menu item. When a user changes the font, it will affect the height of the menu items and change the layout. We should use Javascript to set the correct height because otherwise we will end up with mis-matched heights in a variety of cases. Flexbox would work best but is not cross-browser friendly.

Thoughts? Discuss below...

chriswallace avatar Aug 29 '16 21:08 chriswallace

I think flexbox is definitely not something we can use right now so I suggest we come up with a simple JS solution.

jonathanbardo avatar Aug 30 '16 16:08 jonathanbardo

@chriswallace @jonathanbardo Would the flexbox styles only be used on mobile? Because my understanding is that it's almost universally supported on mobile.

frankiejarrett avatar Aug 30 '16 16:08 frankiejarrett

Closing issues and PRs in preparation for repository archival

aledesma-godaddy avatar Mar 13 '23 19:03 aledesma-godaddy