coblocks
coblocks copied to clipboard
godaddy-wordpress
Update FAQ block to default to h2 title
Description
WPEX-2419
Types of changes
Set the FAQ title to h2, and updated the pa11y.sql test file with the same changes.
How has this been tested?
pa11y run locally.
Acceptance criteria
- Switch the default FAQ block title element to h2 instead of h3
- Update pa11y.sql file with changes from above.
Checklist:
- [x] My code is tested
- [x] I've included any necessary tests
- [x] I've added proper labels to this pull request
Test summary
Run details
| Project | CoBlocks |
| Status | Passed |
| Commit | a0023e7dea |
| Started | Sep 28, 2022 8:30 PM |
| Ended | Sep 28, 2022 8:34 PM |
| Duration | 04:02 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Firefox 105  |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
Performance Test Results:
| index | master | faq-wcag2a | change % |
|---|---|---|---|
| focus | 119.79 | 137.13 | 14.48% |
| inserterHover | 39.2 | 39.86 | 1.68% |
| inserterOpen | 103.66 | 107.4 | 3.61% |
| inserterSearch | 100.55 | 92.52 | -7.99% |
| load | 22397.4 | 22056 | -1.52% |
| maxFocus | 211.2 | 228.69 | 8.28% |
| maxInserterHover | 49.86 | 49.48 | -0.76% |
| maxInserterOpen | 352.33 | 343.7 | -2.45% |
| maxInserterSearch | 193.6 | 186.57 | -3.63% |
| maxType | 75.85 | 100.52 | 32.52% |
| minFocus | 95.69 | 106.49 | 11.29% |
| minInserterHover | 34.25 | 35.29 | 3.04% |
| minInserterOpen | 69.38 | 70.75 | 1.97% |
| minInserterSearch | 52.2 | 47.61 | -8.79% |
| minType | 38.3 | 39.81 | 3.94% |
| type | 46.68 | 50.52 | 8.23% |
Would be cool to try and get this merged in. Will check out what the conflict looks like.
I am not 100% clear on what should be removed from the conflict. That does not seem likely to affect deprecations given it's a default template but it is a possibility. Did we happen to confirm that no deprecations are required here?
@AnthonyLedesma may be best to let @EvanHerman resolve the conflicts, as he is the original committer. Likely we will just want to take the most recent version of the SQL test file, but Evan will know best.
I think this is actually not relevant anymore after we merged in the other pa11y updates. I am pretty sure I made the necessary changes in https://github.com/godaddy-wordpress/coblocks/pull/2434
And our pa11y builds are still passing on master, so I think we can close out this PR.