coblocks
coblocks copied to clipboard
Published
20 hours ago •
godaddy-wordpress
godaddy-wordpress
Fix Carousel block validation errors
Description
Fix the gallery carousel markup and pre/next buttons.
Types of changes
Bug fix (non-breaking change which fixes an issue)
How has this been tested?
Manually tested creating various types of gallery carousels.
Acceptance criteria
Ensure the carousel renders and saves correctly.
Checklist:
- [x] My code is tested
- [x] My code follows accessibility standards
- [x] I've added proper labels to this pull request
Download coblocks.zip: https://output.circle-artifacts.com/output/job/4a42a727-3a6e-4522-9b47-4dcb42f3baaf/artifacts/0/tmp/artifacts/coblocks-2411.zip
Test summary
394 • 
0 • 
2 • 
0
Run details
| Project | CoBlocks |
| Status | Passed |
| Commit | ad36f80014 |
| Started | Jul 21, 2022 6:36 PM |
| Ended | Jul 21, 2022 6:40 PM |
| Duration | 04:18 💡 |
| OS | Linux Ubuntu - 20.04 |
| Browser | Multiple |
View run in Cypress Dashboard ➡️
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard
![cypress[bot] avatar](https://avatars.githubusercontent.com/in/9078?v=4 "Published by a pub.dev verified publisher"){kind=small}
Performance Test Results:
| index | master | fix-gallery-carousel | change % |
|---|---|---|---|
| focus | 108.26 | 120.76 | 11.55% |
| inserterHover | 35.88 | 38.96 | 8.58% |
| inserterOpen | 118.99 | 102.12 | -14.18% |
| inserterSearch | 96.38 | 78.04 | -19.03% |
| load | 22138.9 | 21465.5 | -3.04% |
| maxFocus | 165.49 | 219.37 | 32.56% |
| maxInserterHover | 42.85 | 98.57 | 130.04% |
| maxInserterOpen | 443.19 | 371.27 | -16.23% |
| maxInserterSearch | 188.64 | 176.38 | -6.5% |
| maxType | 71.56 | 98.51 | 37.66% |
| minFocus | 89.56 | 96.89 | 8.18% |
| minInserterHover | 32.38 | 32.9 | 1.61% |
| minInserterOpen | 68.23 | 68.98 | 1.1% |
| minInserterSearch | 51.09 | 50.48 | -1.19% |
| minType | 34.1 | 37.19 | 9.06% |
| type | 43.02 | 46.47 | 8.02% |
Code Coverage: 96.53% 💚
🗂 Folder Coverage
src/blocks/accordion/ 100.00% ✅ src/blocks/accordion/accordion-item/ 100.00% ✅ src/blocks/alert/ 100.00% ✅ src/blocks/author/ 100.00% ✅ src/blocks/buttons/ 100.00% ✅ src/blocks/click-to-tweet/ 100.00% ✅ src/blocks/counter/ 100.00% ✅ src/blocks/dynamic-separator/ 100.00% ✅ src/blocks/events/ 96.43% 💚 src/blocks/events/event-item/ 100.00% ✅ src/blocks/faq/ 100.00% ✅ src/blocks/faq/faq-item/ 100.00% ✅ src/blocks/features/ 100.00% ✅ src/blocks/features/feature/ 100.00% ✅ src/blocks/food-and-drinks/ 100.00% ✅ src/blocks/food-and-drinks/food-item/ 100.00% ✅ src/blocks/form/fields/checkbox/ 100.00% ✅ src/blocks/form/fields/date/ 100.00% ✅ src/blocks/form/fields/hidden/ 100.00% ✅ src/blocks/form/fields/name/ 100.00% ✅ src/blocks/form/fields/phone/ 100.00% ✅ src/blocks/form/fields/radio/ 100.00% ✅ src/blocks/form/fields/select/ 100.00% ✅ src/blocks/form/fields/text/ 100.00% ✅ src/blocks/form/fields/textarea/ 100.00% ✅ src/blocks/form/fields/website/ 100.00% ✅ src/blocks/gallery-carousel/ 96.43% 💚 src/blocks/gallery-collage/ 100.00% ✅ src/blocks/gallery-masonry/ 80.10% 💚 src/blocks/gallery-offset/ 100.00% ✅ src/blocks/gallery-stacked/ 100.00% ✅ src/blocks/gif/ 100.00% ✅ src/blocks/gist/ 100.00% ✅ src/blocks/hero/ 92.56% 💚 src/blocks/highlight/ 100.00% ✅ src/blocks/logos/ 100.00% ✅ src/blocks/map/ 100.00% ✅ src/blocks/media-card/ 96.43% 💚 src/blocks/opentable/ 100.00% ✅ src/blocks/post-carousel/ 100.00% ✅ src/blocks/posts/ 100.00% ✅ src/blocks/pricing-table/ 100.00% ✅ src/blocks/pricing-table/pricing-table-item/ 100.00% ✅ src/blocks/row/ 94.43% 💚 src/blocks/row/column/ 88.54% 💚 src/blocks/services/ 100.00% ✅ src/blocks/services/service/ 100.00% ✅ src/blocks/shape-divider/ 100.00% ✅ src/blocks/share/ 81.25% 💚 src/blocks/social-profiles/ 79.64% 💛 src/blocks/testimonials/ 87.50% 💚 src/blocks/testimonials/testimonial/ 100.00% ✅
From Circle CI build 58108