coblocks icon indicating copy to clipboard operation
coblocks copied to clipboard

ISBAT use size controls with Offset Gallery block

Open AnthonyLedesma opened this issue 3 years ago • 3 comments

Describe the bug:

The Offset Gallery has image size controls that no longer seem to work. It is not clear when or why this feature broke but I have a feeling that it is related to the introduction of GutterControls component. Let's see if we can figure out how long this has been broken.

To reproduce:

  1. Go to Editor and add the Offset Gallery block.
  2. Add images to the Offset Gallery block.
  3. Use size controls in the block sidebar.
  4. Notice how the size control does not impact the gallery.

Expected behavior:

Expect controls to have an effect. See the Carousel gallery for an example of what the controls should do.

Screenshots:

OffsetGallerySizeControls

Isolating the problem:

  • [x] This bug happens with no other plugins activated
  • [x] This bug happens with a default WordPress theme active
  • [x] This bug happens without the Gutenberg plugin active
  • [x] I can reproduce this bug consistently using the steps above

WordPress version:

5.9.1

Gutenberg version:

N/A

AnthonyLedesma avatar Feb 28 '22 22:02 AnthonyLedesma

@AnthonyLedesma this looks to have been resolved . Can we close it?

https://user-images.githubusercontent.com/18115694/157275154-1fd75e55-8632-4adf-81fa-2e288bddb945.mov

snovosel avatar Mar 08 '22 15:03 snovosel

@snovosel Have you tried any other themes? I think this was tt2.

AnthonyLedesma avatar Mar 08 '22 16:03 AnthonyLedesma

i tested on Go, TT2, TT1, and TT and it looks to be fixed

snovosel avatar Mar 08 '22 16:03 snovosel