coblocks icon indicating copy to clipboard operation
coblocks copied to clipboard

Extracting toggle control for Layout Selector into it's own component

Open jrtashjian opened this issue 3 years ago • 1 comments

Description

Extracting an individual control into a new component inside the an individual extensions directory (abstraction and organization). This also migrates the API request from our manual apiFetch to utilizing the getEntityRecord method of the core data store.

How has this been tested?

Manually and with existing end-to-end tests.

Checklist:

  • [x] My code is tested
  • [x] My code follows accessibility standards
  • [x] My code has proper inline documentation
  • [x] I've included any necessary tests
  • [x] I've included developer documentation
  • [x] I've added proper labels to this pull request

jrtashjian avatar Oct 01 '20 17:10 jrtashjian



Test summary

14 162 0 52


Run details

Project CoBlocks
Status Failed
Commit b602cf89b1
Started Oct 1, 2020 5:45 PM
Ended Oct 1, 2020 5:57 PM
Duration 12:00 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Failures

Run group: e2e-firefox (Linux, Firefox )
src/blocks/gallery-collage/test/gallery-collage.cypress.js Failed
1 Test CoBlocks Gallery Collage Block > Test collage block saves with empty values.
2 Test CoBlocks Gallery Collage Block > Test collage block saves with image upload.
3 Test CoBlocks Gallery Collage Block > Test collage block saves with images from media library.
4 Test CoBlocks Gallery Collage Block > Test collage block saves with images captions.
src/blocks/share/test/share.cypress.js Failed
1 Test CoBlocks Share Block > Test the share block saves.
2 Test CoBlocks Share Block > Test the share block colors.
3 Test CoBlocks Share Block > Test the share block rounded corners.
4 Test CoBlocks Share Block > Test the share block button size.
5 Test CoBlocks Share Block > Test the share block social network visibility using sidebar toggle.
6 Test CoBlocks Share Block > Test the share block social network visibility using click toggle.
This comment includes only the first 10 test failures. See all 162 failures in the Cypress Dashboard.
Run group: e2e-chrome (Linux, Chrome )
src/blocks/share/test/share.cypress.js Failed
1 Test CoBlocks Share Block > Test the share block saves.
2 Test CoBlocks Share Block > Test the share block colors.
3 Test CoBlocks Share Block > Test the share block rounded corners.
4 Test CoBlocks Share Block > Test the share block button size.
5 Test CoBlocks Share Block > Test the share block social network visibility using sidebar toggle.
6 Test CoBlocks Share Block > Test the share block social network visibility using click toggle.
7 Test CoBlocks Share Block > Test the share block custom classes and top/bottom spacing.
src/blocks/logos/test/logos.cypress.js Failed
1 Test CoBlocks Logos Block > Test logos block saves with empty values.
2 Test CoBlocks Logos Block > Test logos block saves with image upload.
3 Test CoBlocks Logos Block > Test logos block saves with image from media library.
This comment includes only the first 10 test failures. See all 162 failures in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

cypress[bot] avatar Oct 01 '20 17:10 cypress[bot]