crane
crane copied to clipboard
perf: Optimize the AddClusters function
What type of PR is this?
optimize
What this PR does / why we need it:
When adding a cluster, the remaining clusters will not be interrupted, and it will return after the unified processing is completed, so that the error message can be returned for better positioning, and the related logic can be optimized
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
🎉 Successfully Build Images. Now Support ARM Platforms. Comment Post Time: 2023-05-11 15:29 Git Version: cecb769
Docker Registry
Overview: https://hub.docker.com/u/gocrane
Image | Pull Command |
---|---|
crane-agent:pr-789-cecb769 | docker pull gocrane/crane-agent:pr-789-cecb769 |
dashboard:pr-789-cecb769 | docker pull gocrane/dashboard:pr-789-cecb769 |
metric-adapter:pr-789-cecb769 | docker pull gocrane/metric-adapter:pr-789-cecb769 |
craned:pr-789-cecb769 | docker pull gocrane/craned:pr-789-cecb769 |
Quick Deploy - Helm
helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=gocrane/craned \
--set craned.image.tag=pr-789-cecb769 \
--set metricAdapter.image.repository=gocrane/metric-adapter \
--set metricAdapter.image.tag=pr-789-cecb769 \
--set craneAgent.image.repository=gocrane/crane-agent \
--set craneAgent.image.tag=pr-789-cecb769 \
--set cranedDashboard.image.repository=gocrane/dashboard \
--set cranedDashboard.image.tag=pr-789-cecb769 crane/crane
Coding Registry
Overview: https://finops.coding.net/public-artifacts/gocrane/crane/packages
Image | Pull Command |
---|---|
crane-agent:pr-789-cecb769 | docker pull finops-docker.pkg.coding.net/gocrane/crane/crane-agent:pr-789-cecb769 |
dashboard:pr-789-cecb769 | docker pull finops-docker.pkg.coding.net/gocrane/crane/dashboard:pr-789-cecb769 |
metric-adapter:pr-789-cecb769 | docker pull finops-docker.pkg.coding.net/gocrane/crane/metric-adapter:pr-789-cecb769 |
craned:pr-789-cecb769 | docker pull finops-docker.pkg.coding.net/gocrane/crane/craned:pr-789-cecb769 |
Quick Deploy - Helm
helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=finops-docker.pkg.coding.net/gocrane/crane/craned \
--set craned.image.tag=pr-789-cecb769 \
--set metricAdapter.image.repository=finops-docker.pkg.coding.net/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-789-cecb769 \
--set craneAgent.image.repository=finops-docker.pkg.coding.net/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-789-cecb769 \
--set cranedDashboard.image.repository=finops-docker.pkg.coding.net/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-789-cecb769 crane/crane
Ghcr Registry
Overview: https://github.com/orgs/gocrane/packages?repo_name=crane
Image | Pull Command |
---|---|
crane-agent:pr-789-cecb769 | docker pull ghcr.io/gocrane/crane/crane-agent:pr-789-cecb769 |
dashboard:pr-789-cecb769 | docker pull ghcr.io/gocrane/crane/dashboard:pr-789-cecb769 |
metric-adapter:pr-789-cecb769 | docker pull ghcr.io/gocrane/crane/metric-adapter:pr-789-cecb769 |
craned:pr-789-cecb769 | docker pull ghcr.io/gocrane/crane/craned:pr-789-cecb769 |
Quick Deploy - Helm
helm repo add crane https://finops-helm.pkg.coding.net/gocrane/gocrane
helm install crane -n crane-system --create-namespace \
--set craned.image.repository=ghcr.io/gocrane/crane/craned \
--set craned.image.tag=pr-789-cecb769 \
--set metricAdapter.image.repository=ghcr.io/gocrane/crane/metric-adapter \
--set metricAdapter.image.tag=pr-789-cecb769 \
--set craneAgent.image.repository=ghcr.io/gocrane/crane/crane-agent \
--set craneAgent.image.tag=pr-789-cecb769 \
--set cranedDashboard.image.repository=ghcr.io/gocrane/crane/dashboard \
--set cranedDashboard.image.tag=pr-789-cecb769 crane/crane
This pr optimize the code a little, but not enough, and also it's not a bugfix commit. So maybe not a bootcamp pr in my opinion. The same problem as #780
You can treat him as not a problem, or you can indicate in the project that you do not accept optimized pr submissions
You can treat him as not a problem, or you can indicate in the project that you do not accept optimized pr submissions
If your pr want to be a bootcamp pr, then should follow the guide, if not , i'd like to accept it if the code commit is right.