gocql icon indicating copy to clipboard operation
gocql copied to clipboard

Support vector type

Open lukasz-antoniak opened this issue 1 year ago • 2 comments

Fix #1734.

Complete vector type support for GoCQL. Supports fixed and variable-length vector types (e.g. vector of floats, vector of list of text).

lukasz-antoniak avatar Oct 10 '24 05:10 lukasz-antoniak

Have you tested it with protoV5? If not I would be glad to handle it with #1822.

tengu-alt avatar Oct 15 '24 11:10 tengu-alt

Have you tested it with protoV5?

Hmm protocol v5 shouldn't matter much here, the encoding of the type itself is the same regardless of whether v4 or v5 is being used.

joao-r-reis avatar Oct 15 '24 14:10 joao-r-reis

I'd be curious your thoughts on if implementing this after https://github.com/apache/cassandra-gocql-driver/pull/1855 would've made it easier.

jameshartig avatar Jan 25 '25 22:01 jameshartig

I'd be curious your thoughts on if implementing this after #1855 would've made it easier.

@lukasz-antoniak can you explore this? I imagine that this implementation doesn't have much overlap with #1855 and I'd like to get it in before #1855 if this is the case but I'd like your thoughts on this @lukasz-antoniak

If we do want to get this done before #1855 then we need a rebase on this PR and then I can review it again

joao-r-reis avatar Mar 27 '25 15:03 joao-r-reis

Overall, looks good to me, except this and this.

tengu-alt avatar Apr 09 '25 11:04 tengu-alt

@joao-r-reis: Changed C* versions to run integration tests from 4.0 and 4.1, to 4.1 and 5.0.

lukasz-antoniak avatar Apr 11 '25 12:04 lukasz-antoniak

I'll wait for approvals by @tengu-alt and @OleksiienkoMykyta before merging this

joao-r-reis avatar Apr 11 '25 14:04 joao-r-reis

After they approve please squash the commits and use a commit description according to our guidelines

joao-r-reis avatar Apr 11 '25 14:04 joao-r-reis

@tengu-alt @OleksiienkoMykyta do you have time to review/approve this PR this week?

joao-r-reis avatar Apr 21 '25 09:04 joao-r-reis

@tengu-alt @OleksiienkoMykyta do you have time to review/approve this PR this week?

Sure, I'll check it this week

OleksiienkoMykyta avatar Apr 21 '25 10:04 OleksiienkoMykyta

@lukasz-antoniak can you squash and edit commit msg?

joao-r-reis avatar Apr 22 '25 12:04 joao-r-reis

Done.

lukasz-antoniak avatar Apr 24 '25 11:04 lukasz-antoniak

missing entry on CHANGELOG @lukasz-antoniak

joao-r-reis avatar Apr 24 '25 14:04 joao-r-reis