lifterlms icon indicating copy to clipboard operation
lifterlms copied to clipboard

Published 20 hours ago • verified publisher icon gocodebox

Enqueue styles

Open donaldafeith opened this issue 3 years ago • 2 comments

4 fonts for testing loaded 'no frills' just enqueue version

Description

Fixes #

How has this been tested?

Screenshots

Types of changes

Checklist:

  • [ ] My code has been tested.
  • [ ] My code passes all existing automated tests.
  • [ ] My code follows the LifterLMS Coding & Documentation Standards.

donaldafeith avatar Aug 05 '22 16:08 donaldafeith

@donaldafeith Welcome to the team! I think this is a great first pull into LifterLMS but it's not ready yet. I've made some "suggestions". Please have a look through and let me know if you have any questions!

thomasplevy avatar Aug 05 '22 17:08 thomasplevy

Initially I was in favor of adding only woff2 fonts, but I think we should include woff also, just to be safe for some older browsers.

Font support looks pretty solid to me across the board with woff and woff2.

We don't need to support IE at all anymore and the legacy iOS can absolutely be dropped.

@eri-trabiccolo do you have any thoughts on this?

Ok for woff too, it'll be loaded as fallback only so ok.

eri-trabiccolo avatar Aug 08 '22 19:08 eri-trabiccolo