5.0 Forms Placeholders don't work

[nrherron92]

Reproduction Steps

• Open a form and set a place holder for state in either billing or registration
• From the front end go into fill out the registration form

Expected Behavior

• the placeholder should override the first state in the list

Actual Behavior

• the first state alphabetically displays
• For example if the country is set in LifterLMS Settings to the States, the state field defaults to Alabama instead of a placeholder of "select your state"

Error Messages / Logs

• Include any relevant error messages or log files

<!-- Paste error logs / backtraces below this line -->

System and Environment Information

System Report

Wordpress
-------------------------------------------

Home Url: https://-5-testing.myliftersite.com
Site Url: https://-5-testing.myliftersite.com
Login Url: https://-5-testing.myliftersite.com/wp-login.php
Version: 5.7.2
Debug Mode: Yes
Debug Log: Yes
Debug Display: Yes
Locale: en_US
Multisite: No
Page For Posts: Not Set
Page On Front: Homepage (#155) [https://-5-testing.myliftersite.com/]
Permalink Structure: /%postname%/
Show On Front: page
Wp Cron: Yes


Settings
-------------------------------------------

Version: 5.1.0
Db Version: 5.1.0
Course Catalog: Not Set
Membership Catalog: Membership Catalog (#10) [https://-5-testing.myliftersite.com/memberships/]
Student Dashboard: Student Dashboard (#12) [https://-5-testing.myliftersite.com/dashboard/]
Checkout Page: Purchase (#11) [https://-5-testing.myliftersite.com/purchase/]
Course Catalog Per Page: -1
Course Catalog Sorting: menu_order,ASC
Membership Catalog Per Page: 9
Membership Catalog Sorting: menu_order,ASC
Site Membership: Not Set
Courses Endpoint: my-courses
Edit Endpoint: edit-account
Lost Password Endpoint: lost-password
Vouchers Endpoint: redeem-voucher
Autogenerate Username: yes
Password Strength Meter: yes
Minimum Password Strength: strong
Terms Required: yes
Terms Page: Block Content Examples (#156) [https://-5-testing.myliftersite.com/?page_id=156]
Checkout Names: required
Checkout Address: required
Checkout Phone: optional
Checkout Email Confirmation: yes
Open Registration: yes
Registration Names: required
Registration Address: optional
Registration Phone: hidden
Registration Voucher: optional
Registration Email Confirmation: no
Account Names: required
Account Address: required
Account Phone: optional
Account Email Confirmation: yes
Confirmation Endpoint: confirm-payment
Force Ssl Checkout: no
Country: US
Currency: USD
Currency Position: left
Thousand Separator: ,
Decimal Separator: .
Decimals: 2
Trim Zero Decimals: no
Recurring Payments: yes
Email From Address: [email protected]
Email From Name: A LifterLMS Sandbox
Email Footer Text: 
Email Header Image: 
Cert Bg Width: 800
Cert Bg Height: 616
Cert Legacy Compat: no


Constants
-------------------------------------------

LLMS_REMOVE_ALL_DATA: undefined
LLMS_REST_DISABLE: undefined
LLMS_SITE_FEATURE_RECURRING_PAYMENTS: undefined
LLMS_SITE_IS_CLONE: undefined


Gateways
-------------------------------------------

Manual: Enabled
Manual Logging: no
Manual Order: 1


Server
-------------------------------------------

Mysql Version: 5.7.34
Php Curl: Yes
Php Default Timezone: UTC
Php Fsockopen: Yes
Php Max Input Vars: 5000
Php Max Upload Size: 512 MB
Php Memory Limit: 256M
Php Post Max Size: 1024M
Php Soap: Yes
Php Suhosin: No
Php Time Limt: 30
Php Version: 7.3.29
Software: Apache/2.4.48 (Unix) OpenSSL/1.1.1
Wp Memory Limit: 256M


Browser
-------------------------------------------

HTTP USER AGENT: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/91.0.4472.164 Safari/537.36


Theme
-------------------------------------------

Name: Astra
Version: 3.6.4
Themeuri: https://wpastra.com/
Authoruri: https://wpastra.com/about/
Template: 
Child Theme: No
Llms Support: Yes


Plugins
-------------------------------------------

BuddyPress: 8.0.0
LifterLMS: 5.1.0
LifterLMS Custom Fields: 2.0.0
LifterLMS PDFs: 1.0.0


Integrations
-------------------------------------------

BbPress: No
BuddyPress: Yes


Template Overrides
-------------------------------------------

This issue has be recreated:

• [x] Locally
• [X] On a staging site
• [X] On a production website
• [X] With only LifterLMS and a default theme

Browser, Device, and Operating System Information

• Browser name and version
• Operating System name and version
• Device name and version (if applicable)

[thomasplevy]

@nrherron92 confirmed bug, at this moment I don't see us getting a fix in for this prioritized this week. Do you have a sense as to whether or not this is a critical issue that requires more immediate attention or can we let the user know it's a bug and we'll have a fix for it in the next few weeks and thanks for being patient, etc...?

[nrherron92]

@thomasplevy it seems like it's causing him issues where his users just leave Alabama and don't choose their own state. I don't think it needs to necessarily be fixed this week but sooner rather than later?

[nrherron92]

HS-189688

[thomasplevy]

@nrherron92 I have this on the indefinite backlog as of this moment. Does this ticket suggest we should adjust priority?

[nrherron92]

@thomasplevy For this user the issue seems to be that her students expect their (for example) chrome autofill to take over and this is not updating Alabama to the autofill state, then they don't check their information is correct and just run their payment and get bounced back.

I don't think this is urgent.

We've only had 2 people complain about this since the release (i see i forgot to add the original ticket 🤦🏼‍♀️ ) but this maybe gives us more of an idea of the use case for why it needs to be updated?

[donaldafeith]

I am pulling a fix for this to help until I can rework the Javascript. Select2 is iffy when it comes to multiple options.