gochain
The float64 issue... again
floats are just outright rejected as of this commit: https://github.com/gochain/web3/commit/a94ed0a6f123f02748824f6b7c49f4f53d064a36
Which makes it annoying for JSON users.
Two ideas to make this a bit smoother.
- Allow whole numbers to pass through, eg:
if f == math.Trunc(f) - Put more info into the error that rejects float64's, such as
if you are parsing JSON, use decoder.UseNumber()
Actually, it appears that it already did the same thing as 1 here. Why wasn't that acceptable?
Information can be lost beforehand that the trunc check won't catch. Even a whole number integer could actually change into a different whole number integer (e.g. 10000000000000001->10000000000000000). The PR (#135) shows some examples.
It would be convenient to still accept float64 in some narrow cases to accommodate users that already have a float64 (and no lossy conversion happening first to 'correct'), but that ofc simultaneously exposes other users to accidental bugs, so asking the few users already stuck with float64s to convert explicitly seems like a minimal burden.
The doc says:
// Note: The encoding/json package uses float64 for numbers by default, which is inaccurate
// for many web3 types, and unsupported here. The json.Decoder method UseNumber() will
// switch to using json.Number instead, which is accurate (full precision, backed by the
// original string) and supported here.
And the current error is: floating point numbers are not valid in web3 - please use an integer or string instead (including big.Int and json.Number)
How about adding this?
-floating point numbers are not valid in web3 - please use an integer or string instead (including big.Int and json.Number)
+floating point numbers are not valid in web3 - please use an integer or string instead (including big.Int and json.Number) - see json.Decoder.UseNumber()
