#180 fix for destinationTable not returned

[prabhav007]

closes #180

[pyama86]

I have the same problem. How about I take over if there is no progress?

[kromiii]

I applied these changes to my branch, and it resolved the error. These changes would be necessary for using ruby-client for the bigquery-emulator.

[anderseriksson]

I applied these changes to my branch, and it resolved the error. These changes would be necessary for using ruby-client for the bigquery-emulator.

Yes your changes and your image solved a similar problem when I issue a query with a specific JobId. I hope we can have this fix merged in to goccy project and image.

[benvdh-incentro]

@yaronneuman it seems your question has been answered 3 weeks ago by someone else. Also others mention the code works well... is there anything that's still keeping you from getting this merged? Getting this fixed can also help to resolve an issue being the discussed in the DBT community:

https://github.com/dbt-labs/dbt-bigquery/issues/358

@goccy can you help perhaps?

[goccy]

@benvdh-incentro Thank you, I've commented https://github.com/goccy/bigquery-emulator/pull/187/files#r1332797665

[benvdh-incentro]

@goccy I see @prabhav007 and @kromiii have delivered some test code and further rationale behind the current PR, anything else that is still needed to get this merged?

[goccy]

The reason I cannot merge this PR is that there is no test code in this repository that corresponds to the modification. If there is no test code, I need to determine the validity of the modification from the diffs, which is currently difficult.

[simi]

I can confirm this breaks Ruby client. :thinking: Any idea how to move this forward? Even with this patch only query like SELECT * FROM finance_v2_local.statements_2 works, but query like SELECT * FROM finance_v2_local.statements_2 WHERE Artist = 'ABC' fails since missing destination dataset table. It seems to be related to fact if query returns any value. For queries with 0 returned rows it fails per https://github.com/goccy/bigquery-emulator/blob/316038b8dd3f6534a87948f28ac54c41dc6afc21/server/handler.go#L1427.

I have checked BQ response and it returns destination table even for empty result.

[simi]

@kromiii I can try to help with writing test, but seems destination table is not tested currently at all.