krop icon indicating copy to clipboard operation
krop copied to clipboard

snapped krop crashed with "TypeError: QLineEdit.setText(str): argument 1 has unexpected type 'tuple'"

Open brlin-tw opened this issue 6 years ago • 7 comments

Bug Reproduction Info

  • I was editing the filename in the save file dialog
  • The bug is produced under the condition that no input file is opened(at the time I didn't notice there's an Open button on the menu/toolbar

Console Output

$ snap run krop.krop-app
libGL error: MESA-LOADER: failed to retrieve device information
libGL error: Version 4 or later of flush extension not found
libGL error: failed to load driver: i915
libGL error: MESA-LOADER: failed to retrieve device information
"Qt Warning: Compose file: \"/usr/share/X11/locale/en_US.UTF-8/Compose\" can't be found"
Traceback (most recent call last):
  File "/snap/krop/104/lib/python3.5/site-packages/krop/mainwindow.py", line 236, in slotSelectFile
    self.ui.editFile.setText(fileName)
TypeError: QLineEdit.setText(str): argument 1 has unexpected type 'tuple'
已經終止 (core dumped)

Additional Info

  • I am using an input method framework called Fcitx

  • The host's locale settings:

      LANG=zh_TW.UTF-8
      LANGUAGE=zh_TW:zh_CN
      LC_CTYPE="zh_TW.UTF-8"
      LC_NUMERIC="zh_TW.UTF-8"
      LC_TIME="zh_TW.UTF-8"
      LC_COLLATE="zh_TW.UTF-8"
      LC_MONETARY="zh_TW.UTF-8"
      LC_MESSAGES="zh_TW.UTF-8"
      LC_PAPER="zh_TW.UTF-8"
      LC_NAME="zh_TW.UTF-8"
      LC_ADDRESS="zh_TW.UTF-8"
      LC_TELEPHONE="zh_TW.UTF-8"
      LC_MEASUREMENT="zh_TW.UTF-8"
      LC_IDENTIFICATION="zh_TW.UTF-8"
      LC_ALL=
    

brlin-tw avatar Jun 30 '18 16:06 brlin-tw

The locale issue is fixed by connecting the snap to the desktop-* interface, but the crash is still reproduced. I suspect it is an upstream bug.

brlin-tw avatar Jul 01 '18 10:07 brlin-tw

Thank you @Lin-Buo-Ren! This is indeed an upstream bug. It will be fixed in the next release (it already is fixed on GitHub).

arminstraub avatar Oct 27 '18 14:10 arminstraub

Thank you @Lin-Buo-Ren! This is indeed an upstream bug. It will be fixed in the next release (it already is fixed on GitHub).

Is this fix already released?

edumco avatar Apr 28 '20 00:04 edumco

I believe this was fixed in version 0.5.1 at: https://github.com/arminstraub/krop

arminstraub avatar May 26 '20 19:05 arminstraub

@gocarlos Could you explain how to upgrade the krop version from upstream?

I would like to create an automation for this process so we can include this in CI

edumco avatar May 27 '20 17:05 edumco

@edumco sorry for the late response, I'm looking at it right now

gocarlos avatar Jul 20 '20 15:07 gocarlos

@Lin-Buo-Ren could you retest with the latest version (0.6.0), released to the snap store 30min ago

gocarlos avatar Jul 20 '20 17:07 gocarlos