gocardless-pro-java icon indicating copy to clipboard operation
gocardless-pro-java copied to clipboard

CustomerCreateRequest.withMetadata() is using pre 5.18.1 signature of MetaData

Open grafjo opened this issue 2 years ago • 1 comments

In Release 5.18.1 introduced MetaData Map with signature Map<String, Object>

You missed adjusting CustomerService CustomerCreateRequest.withMetadata(Map<String, String> metadata) - this is still using the old signature - see https://github.com/gocardless/gocardless-pro-java/blob/master/src/main/java/com/gocardless/services/CustomerService.java#L201

grafjo avatar Jun 24 '23 21:06 grafjo

Hey @grafjo ,

Thanks for sending this over. We are working on a fix to properly generate types for generic objects based on schema pattern properties.

Nimisoere avatar Jun 25 '23 15:06 Nimisoere