pop
pop copied to clipboard
gobuffalo
Support MS SQL Server
Of course! I’m happy to offer guidance. @mclark4386 implemented cockroach support recently. I’m sure he’ll be happy to offer some guidance along the way too!
@markbates So I took a glance at the cockroach commits and if I understand correctly the main task would be to implement sqlserver.go and fizz/translators/sqlserver.go similar to mysql/postgres/cockroach. Is that right?
That’s the basics of it, yep. I would pick the implementation that’s closest to MS, I’ve never used it, and use that as a starting point. Rename a few things, point them at the MS DB and see what the tests yell at you about.
@markbates hmm... travis doesn't support ms sql server. would you consider to add appveyor integration? https://www.appveyor.com/
Sure. We use it for Buffalo too. Travis also supports docker, if that helps.
Mark Bates
On Mar 22, 2018, 4:59 PM -0400, marpio [email protected], wrote:
@markbates hmm... travis doesn't support ms sql server. would you consider to add appveyor integration? https://www.appveyor.com/ — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
@markbates true - i've found this: https://github.com/aspnet/EntityFrameworkCore/pull/7842/files I'll go with travis then.
@marpio happy to help if you have questions! Sounds like you have a good start going.
@markbates short question - what is the purpose of the {db}_meta.go files in the fiz/translators package? Why doesn't postgres need it?
Some of the translators, like SQLite (for example), need additional meta information about the table(s), indexes, etc… to create the proper sql for things such as renaming a column.
Postgres is a nice db and things just work. :)
I'm having some difficulties - sqlx doesn't support the sqlserver parameter syntax so:
// this doesn't work
tx.MustExec("INSERT INTO person (first_name, last_name, email) VALUES ($1, $2, $3)", "Jason", "Moiron", "[email protected]")
// this works
tx.MustExec("INSERT INTO person (first_name, last_name, email) VALUES (@p1, @p2, @p3)", "Jason", "Moiron", "[email protected]")
// but this doesn't
tx.NamedExec("INSERT INTO person (first_name, last_name, email) VALUES (:first_name, :last_name, :email)", &Person{"Jane", "Citizen", "[email protected]"})
// neither does this
tx.NamedExec("INSERT INTO person (first_name, last_name, email) VALUES (@first_name, @last_name, @email)", &Person{"Jane", "Citizen", "[email protected]"})
there is this issue jmoiron/sqlx#374 regarding this problem but it doesn't seem to be active.
The second problem is that sqlserver doesn't support the usual LIMIT and OFFSET syntax so i would need to somehow override the buildPaginationClauses function...
Any ideas how this could be solved?
You probably need to implement your own TranslateSQL function like Postgres does https://github.com/gobuffalo/pop/blob/master/postgresql.go
I did that but the problem is, sqlx can not map to the fields in an struct, if i pass the params in form '@field_name' instead of ':field_name' so things like:
tx.NamedExec("INSERT INTO person (first_name, last_name, email) VALUES (@first_name, @last_name, @email)", &Person{"Jane", "Citizen", "[email protected]"})
sqlx does not recognize the '@field_name' and can't bind it.
this doesn't work either:
st, _ := tx.PrepareNamed("INSERT INTO person (first_name, last_name, email) VALUES (@first_name, @last_name, @email)")
st.Exec(&Person{"Jane", "Citizen", "[email protected]"})
@marpio jmoiron/sqlx#406 was merged, and I just merged your PR in fizz. :)
Awesome @stanislas-m I will need some time to make it work since a lot changed in buffalo/pop since March.
@Norris1z I'm quite busy these days and not sure when I get to it. Probably in 2-3 months. Sorry for that. Feel free to take this one if you're interested!
I'm interesting in this. I'm a little green when it comes to Go, and would want to chat about what the scope of work looks like before volunteering to take this on. Gopher slack the best place for that?
@andyedison Sure, feel free to join the buffalo-dev channel on Gopher slack. :)