analyzer icon indicating copy to clipboard operation
analyzer copied to clipboard

Avoid eager string conversions during analysis

Open sim642 opened this issue 4 months ago • 0 comments

But the other worrying point is that we're apparently printing something during solving itself. That's unusual, because usually it's just one solver stats printout after another. Perhaps there's some internal unnecessary string conversion taking place as well.

The analyses should not be using Pretty to convert things to strings during the analysis (unless warn_at is early at least). I may be wrong, but I can't currently think of a legitimate reason to do that. It might help to do an sv-benchmarks run with -v to get the backtrace at that point. I think the backtrace should still contain the entire non-signal-handler stack, so it would expose where are we using Pretty during analysis.

Of course avoiding that isn't a particularly reliable fix, but it would make sense to avoid it anyway for performance reasons.

Originally posted by @sim642 in #1781

sim642 avatar Jul 30 '25 14:07 sim642