analyzer icon indicating copy to clipboard operation
analyzer copied to clipboard

Remove duplicate `ctx`-derived arguments in base analysis

Open sim642 opened this issue 9 months ago • 1 comments

Base analysis is full of code like

set_many ~ctx (Analyses.ask_of_ctx ctx) gs st [...]

where Analyses.ask_of_ctx ctx, gs and st are directly taken from ctx itself. There's no point in having those three arguments because everything could be accessed via the ctx that's already passed around.

This is the case for a lot of code in base, so this would be a major cleanup.

sim642 avatar Nov 22 '23 09:11 sim642

Reopening because many st arguments still remain after #1308 due to possible mismatch between ctx.local and st in the middle of certain operations: https://github.com/goblint/analyzer/pull/1308#discussion_r1445953004.

sim642 avatar Jan 24 '24 11:01 sim642