analyzer icon indicating copy to clipboard operation
analyzer copied to clipboard

`DefExc.of_interval` ignores interval

Open sim642 opened this issue 2 years ago • 0 comments

I don't think it's problematic, inside this domain the ikind is not stored and only used to compute the ranges:

https://github.com/goblint/analyzer/blob/4d18300af5f6ae1b04bdbf29b29775af07fbc96c/src/cdomains/intDomain.ml#L2157

https://github.com/goblint/analyzer/blob/4d18300af5f6ae1b04bdbf29b29775af07fbc96c/src/cdomains/intDomain.ml#L1989

Originally posted by @michael-schwarz in https://github.com/goblint/analyzer/pull/1154#discussion_r1321208784


Hmm, that makes it quite misleading though. The result is based on IBool, not (BigInt.zero, BigInt.one) at all. So right now this is the only way anyway.

But we should open an issue about fixing DefExc.of_interval to actually derive a bit range from the actual given interval and intersect it with the ikind's range. I didn't check but starting and ending should work similarly. It might make a difference because base analysis itself uses of_interval/starting/ending.

Originally posted by @sim642 in https://github.com/goblint/analyzer/pull/1154#discussion_r1321423977

sim642 avatar Sep 12 '23 07:09 sim642