nova-copilot-lsp icon indicating copy to clipboard operation
nova-copilot-lsp copied to clipboard

[BUG] Dosen't show device activation code

Open BenjaminHoegh opened this issue 2 years ago • 11 comments
trafficstars

Is there an existing issue for this?

  • [X] I have searched the existing issues

Current Behavior

Skærmbillede 2023-05-23 kl  19 00 01

Expected Behavior

No response

Steps To Reproduce

No response

Environment

No response

Relevant log output

No response

Anything else?

No response

BenjaminHoegh avatar May 23 '23 17:05 BenjaminHoegh

Also experiencing this in Nova 11.0

devinbaeten avatar May 23 '23 17:05 devinbaeten

Same issue for me in Nova 11

Westindies972 avatar May 24 '23 11:05 Westindies972

It doesn't display but it was in my clipboard. Just paste it in when the browser tab opens

P-James avatar May 25 '23 01:05 P-James

Thanks a lot, I just tried, it was in my clipboard.

Westindies972 avatar May 25 '23 01:05 Westindies972

OMG. So it was in my clipboard!

halfnibble avatar Jun 08 '23 06:06 halfnibble

It’s quite convenient that you put the code in our clipboard during the auth flow, but from a UX standpoint this is very bad.

Writing to the clipboard without a users knowledge could lead to loss of data and or (evidently) confusion.

Please consider making an alert that displays the code or a prompt asking to save the code to the clipboard.

devinbaeten avatar Jun 29 '23 22:06 devinbaeten

Feel free to open a PR an I'll review it :)

gobijan avatar Jul 03 '23 12:07 gobijan

Yes same here... I have lost a lot of time to just finally found someone somewhere that says that it should be copied in the clipboard... Men, if you can't show an alert window, please write something in the extension console at least that says "Device code copied in clipboard... Just have to past it in the GitHub Page" !!!

wptechnology avatar Aug 14 '23 16:08 wptechnology

This was just a quick exploration to see if it was feasible. At the moment I do not plan on allocating time to this extension.

Feel free to create a PR with documentation fixes and the alert and log improvements. This shouldn't be too hard. Give it a try :)

gobijan avatar Aug 14 '23 17:08 gobijan

Solution documented in https://github.com/gobijan/nova-copilot-lsp/pull/8

TheBoatyMcBoatFace avatar Sep 06 '23 15:09 TheBoatyMcBoatFace

BenjaminHoegh

Have you tried it with the new docs? I hate to say _it worked for me, but when I ran through the nvim steps, things were groovy.

Here are the docs I'm taking about

TheBoatyMcBoatFace avatar Sep 08 '23 16:09 TheBoatyMcBoatFace