authentik icon indicating copy to clipboard operation
authentik copied to clipboard

sources/oauth: use id_tokens for Azure AD source instead of the userinfo endpoint

Open silenium-dev opened this issue 1 year ago • 3 comments

Details

This PR replaces the userinfo request in Azure AD source by getting an id_token together with the authorization_code (#9871).

Closes #9871


Checklist

  • [ ] Local tests pass (ak test authentik/)
  • [ ] The code has been formatted (make lint-fix)

If an API change has been made

  • [ ] The API schema has been updated (make gen-build)

~~If changes to the frontend have been made~~

~~- [ ] The code has been formatted (make web)~~

If applicable

  • [ ] The documentation has been updated
  • [ ] The documentation has been formatted (make website)

silenium-dev avatar May 26 '24 17:05 silenium-dev

Deploy Preview for authentik-docs canceled.

Name Link
Latest commit b6e0050378680478069acfa1e7e65a64bb28deae
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/665376dbd702050008904f40

netlify[bot] avatar May 26 '24 17:05 netlify[bot]

Deploy Preview for authentik-storybook canceled.

Name Link
Latest commit b6e0050378680478069acfa1e7e65a64bb28deae
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/665376db541aab00080fd8cc

netlify[bot] avatar May 26 '24 17:05 netlify[bot]

Codecov Report

Attention: Patch coverage is 50.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 51.03%. Comparing base (2cff3d1) to head (b6e0050). Report is 948 commits behind head on main.

Files with missing lines Patch % Lines
authentik/sources/oauth/types/azure_ad.py 41.93% 18 Missing :warning:
authentik/sources/oauth/clients/oauth2.py 50.00% 1 Missing :warning:

:exclamation: There is a different number of reports uploaded between BASE (2cff3d1) and HEAD (b6e0050). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (2cff3d1) HEAD (b6e0050)
unit 3 0
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #9872       +/-   ##
===========================================
- Coverage   92.63%   51.03%   -41.61%     
===========================================
  Files         710      708        -2     
  Lines       34745    34513      -232     
===========================================
- Hits        32186    17613    -14573     
- Misses       2559    16900    +14341     
Flag Coverage Δ
e2e 49.65% <50.00%> (+<0.01%) :arrow_up:
integration 25.50% <34.21%> (+<0.01%) :arrow_up:
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 30 '24 11:05 codecov[bot]