authentik icon indicating copy to clipboard operation
authentik copied to clipboard

docker-compose: remove version top level element

Open 4d62 opened this issue 9 months ago β€’ 6 comments

Details

This pull request removes the version top level element from the docker-compose.yml as it causes an unnecessary warning that can be avoided. See https://github.com/compose-spec/compose-spec/blob/master/04-version-and-name.md


Checklist

  • [ ] Local tests pass (ak test authentik/)
  • [ ] The code has been formatted (make lint-fix)

If an API change has been made

  • [ ] The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • [ ] The code has been formatted (make web)

If applicable

  • [ ] The documentation has been updated
  • [ ] The documentation has been formatted (make website)

4d62 avatar May 07 '24 21:05 4d62

Deploy Preview for authentik-storybook canceled.

Name Link
Latest commit 6e823b23f8a41a19c2017e780621caf10c2b502e
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/664252e1e994020008540b96

netlify[bot] avatar May 07 '24 21:05 netlify[bot]

Deploy Preview for authentik-docs ready!

Name Link
Latest commit 6e823b23f8a41a19c2017e780621caf10c2b502e
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/664252e1a7e1880008b485fc
Deploy Preview https://deploy-preview-9631--authentik-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar May 07 '24 21:05 netlify[bot]

There are other places where we can remove this as like, such as https://docs.goauthentik.io/docs/outposts/manual-deploy-docker-compose

rissson avatar May 13 '24 11:05 rissson

There are other places where we can remove this as like, such as https://docs.goauthentik.io/docs/outposts/manual-deploy-docker-compose

I think this should be all of them. Searched with file name instead of something like version in my first commit

4d62 avatar May 13 '24 15:05 4d62

... (forgot to git pull / rebase issues)

4d62 avatar May 13 '24 17:05 4d62

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.38%. Comparing base (ed214b4) to head (6e823b2). Report is 43 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9631      +/-   ##
==========================================
+ Coverage   92.35%   92.38%   +0.03%     
==========================================
  Files         688      704      +16     
  Lines       33639    34401     +762     
==========================================
+ Hits        31068    31783     +715     
- Misses       2571     2618      +47     
Flag Coverage Ξ”
e2e 49.66% <ΓΈ> (+0.16%) :arrow_up:
integration 25.36% <ΓΈ> (-0.29%) :arrow_down:
unit 89.82% <ΓΈ> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar May 13 '24 19:05 codecov[bot]