authentik icon indicating copy to clipboard operation
authentik copied to clipboard

expressions: add restricted evaluator

Open rissson opened this issue 1 year ago • 7 comments

Details

Very much a WIP, I've only tested it a bit, and it seems to work with our existing blueprints. It also throws errors when trying to import something. Haven't tested stuff like open.

We also probably need to come up with a list of stuff to import "by default". For now I have the following, feel free to edit this description to add more:

  • json
  • yaml
  • re

Checklist

  • [ ] Local tests pass (ak test authentik/)
  • [ ] The code has been formatted (make lint-fix)

If an API change has been made

  • [ ] The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • [ ] The code has been formatted (make web)
  • [ ] The translation files have been updated (make i18n-extract)

If applicable

  • [ ] The documentation has been updated
  • [ ] The documentation has been formatted (make website)

rissson avatar Dec 27 '23 13:12 rissson

Deploy Preview for authentik-storybook ready!

Name Link
Latest commit efdecf949d8c6dc5c2e207e2b1d06892f257087b
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/662fdd40c2ab1500071ed4d4
Deploy Preview https://deploy-preview-8002--authentik-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 27 '23 13:12 netlify[bot]

Codecov Report

Attention: Patch coverage is 77.04918% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 52.18%. Comparing base (c5b0998) to head (efdecf9). Report is 1 commits behind head on main.

Files Patch % Lines
authentik/lib/expression/evaluator.py 83.90% 14 Missing :warning:
authentik/api/authentication.py 14.28% 6 Missing :warning:
authentik/policies/expression/tests.py 0.00% 6 Missing :warning:
authentik/lib/tests/test_evaluator.py 0.00% 2 Missing :warning:
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #8002       +/-   ##
===========================================
- Coverage   92.45%   52.18%   -40.28%     
===========================================
  Files         669      670        +1     
  Lines       32712    32813      +101     
===========================================
- Hits        30245    17124    -13121     
- Misses       2467    15689    +13222     
Flag Coverage Δ
e2e 50.74% <77.04%> (+0.09%) :arrow_up:
integration 26.07% <48.36%> (+0.08%) :arrow_up:
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Dec 27 '23 13:12 codecov[bot]

Deploy Preview for authentik ready!

Name Link
Latest commit 365809ff3466862bb70f660c71ca0c15ad49285a
Latest deploy log https://app.netlify.com/sites/authentik/deploys/658c2ea8f9d1630008c3cf03
Deploy Preview https://deploy-preview-8002--authentik.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Dec 27 '23 14:12 netlify[bot]

TODO: look into making a Runtime abstraction TODO: use python client instead of importing models

rissson avatar Dec 28 '23 13:12 rissson

Note to self: pre-importing django models won't prevent access to other tenants' data, as you can do Model.objects.raw() and type whatever sql you'd like.

rissson avatar Jan 03 '24 11:01 rissson

Deploy Preview for authentik-docs ready!

Name Link
Latest commit efdecf949d8c6dc5c2e207e2b1d06892f257087b
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/662fdd401830cb0008dd1d61
Deploy Preview https://deploy-preview-8002--authentik-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Mar 13 '24 22:03 netlify[bot]