authentik icon indicating copy to clipboard operation
authentik copied to clipboard

Patch sms api

Open samip5 opened this issue 2 years ago β€’ 2 comments

Changes

Breaking Changes

  • Potentially breaking change to the SMS generic payload as it was changed.

Additional

It did not make sense to have them uppercased.

samip5 avatar Aug 14 '22 18:08 samip5

Deploy Preview for authentik ready!

Name Link
Latest commit 25665e8bfd4f002c6303199b74c3c3da811d4b7a
Latest deploy log https://app.netlify.com/sites/authentik/deploys/6322826e8de8c700082dc151
Deploy Preview https://deploy-preview-3417--authentik.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

netlify[bot] avatar Aug 14 '22 18:08 netlify[bot]

Codecov Report

Base: 92.11% // Head: 92.11% // No change to project coverage :thumbsup:

Coverage data is based on head (25665e8) compared to base (4a91a7d). Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3417   +/-   ##
=======================================
  Coverage   92.11%   92.11%           
=======================================
  Files         456      456           
  Lines       22031    22031           
=======================================
  Hits        20291    20291           
  Misses       1740     1740           
Impacted Files Coverage Ξ”
authentik/stages/authenticator_sms/models.py 74.29% <ΓΈ> (ΓΈ)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov[bot] avatar Aug 14 '22 18:08 codecov[bot]

@BeryJu If this is not going to get merged, how would you entail the templating thing to work or should I even try to make that?

samip5 avatar Oct 12 '22 13:10 samip5

https://github.com/goauthentik/authentik/pull/3780

BeryJu avatar Oct 13 '22 20:10 BeryJu