core: move files in database
Details
REPLACE ME
Checklist
- [ ] Local tests pass (
ak test authentik/) - [ ] The code has been formatted (
make lint-fix)
If an API change has been made
- [ ] The API schema has been updated (
make gen-build)
If changes to the frontend have been made
- [ ] The code has been formatted (
make web)
If applicable
- [ ] The documentation has been updated
- [ ] The documentation has been formatted (
make website)
Deploy Preview for authentik-docs canceled.
| Name | Link |
|---|---|
| Latest commit | d410083cfcf1c4d598512f18859b6b6e2d4ecc65 |
| Latest deploy log | https://app.netlify.com/projects/authentik-docs/deploys/684c5277ea29150008c37fe2 |
Deploy Preview for authentik-storybook canceled.
| Name | Link |
|---|---|
| Latest commit | d410083cfcf1c4d598512f18859b6b6e2d4ecc65 |
| Latest deploy log | https://app.netlify.com/projects/authentik-storybook/deploys/684c5277c1ce850008a70f50 |
Codecov Report
:x: Patch coverage is 88.37209% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 71.61%. Comparing base (81e5fef) to head (d410083).
:warning: Report is 1223 commits behind head on main.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| authentik/core/models.py | 80.76% | 5 Missing :warning: |
:exclamation: There is a different number of reports uploaded between BASE (81e5fef) and HEAD (d410083). Click for more details.
HEAD has 10 uploads less than BASE
Flag BASE (81e5fef) HEAD (d410083) e2e 8 7 unit 15 6
Additional details and impacted files
@@ Coverage Diff @@
## main #15035 +/- ##
===========================================
- Coverage 92.81% 71.61% -21.20%
===========================================
Files 815 816 +1
Lines 42112 42154 +42
===========================================
- Hits 39086 30189 -8897
- Misses 3026 11965 +8939
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 47.00% <83.72%> (-0.67%) |
:arrow_down: |
| integration | 24.37% <44.18%> (+0.02%) |
:arrow_up: |
| unit | 66.82% <88.37%> (-23.84%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
- doing things with a separate model is good
- put it in a new app
- for database storage, needs test/benchmarking for performance
existing and potential use cases:
- icons
- backgrounds
- csv reports
- pdf reports
- avatars
- rac session recording -> probably needs to go into s3 directly from the outpost whatever happens because of size