authentik icon indicating copy to clipboard operation
authentik copied to clipboard

core: expiring model: don't synchronously delete

Open rissson opened this issue 1 year ago • 6 comments

Details

REPLACE ME


Checklist

  • [ ] Local tests pass (ak test authentik/)
  • [ ] The code has been formatted (make lint-fix)

If an API change has been made

  • [ ] The API schema has been updated (make gen-build)

If changes to the frontend have been made

  • [ ] The code has been formatted (make web)

If applicable

  • [ ] The documentation has been updated
  • [ ] The documentation has been formatted (make website)

rissson avatar Oct 15 '24 12:10 rissson

Deploy Preview for authentik-storybook canceled.

Name Link
Latest commit 929e42d3f2cc393b4d20ac6d3336d1aa817e9087
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/670e654d2e582c0008ebe45a

netlify[bot] avatar Oct 15 '24 12:10 netlify[bot]

Deploy Preview for authentik-docs canceled.

Name Link
Latest commit 929e42d3f2cc393b4d20ac6d3336d1aa817e9087
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/670e654db4a16c0008317cfb

netlify[bot] avatar Oct 15 '24 12:10 netlify[bot]

Need to make sure we don't break like https://github.com/goauthentik/authentik/issues/3233

rissson avatar Oct 15 '24 12:10 rissson

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.51%. Comparing base (0a1d283) to head (929e42d). Report is 3 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11688      +/-   ##
==========================================
- Coverage   92.77%   92.51%   -0.26%     
==========================================
  Files         736      736              
  Lines       36603    36613      +10     
==========================================
- Hits        33957    33874      -83     
- Misses       2646     2739      +93     
Flag Coverage Δ
e2e 48.76% <85.71%> (-0.63%) :arrow_down:
integration 24.98% <85.71%> (+0.02%) :arrow_up:
unit 90.21% <100.00%> (+<0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 15 '24 12:10 codecov[bot]

This definitely breaks other things

rissson avatar Oct 15 '24 12:10 rissson

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-929e42d3f2cc393b4d20ac6d3336d1aa817e9087-arm64

Afterwards, run the upgrade commands from the latest release notes.

github-actions[bot] avatar Oct 15 '24 13:10 github-actions[bot]