authentik
authentik copied to clipboard
allow null application slug/name from related field
Details
Workaround for required=False not being honored by django-rest-framework and/or drf_spectacular. Fixes goauthentik#9787 (for python bindings, at least).
This at least allows responses to be validated, however schema.yml still lists these response fields as required.
Checklist
- [ ] Local tests pass (
ak test authentik/) - [x] The code has been formatted (
make lint-fix)
If an API change has been made
- [x] The API schema has been updated (
make gen-build)
If changes to the frontend have been made
- [ ] The code has been formatted (
make web)
If applicable
- [ ] The documentation has been updated
- [ ] The documentation has been formatted (
make website)
Deploy Preview for authentik-storybook ready!
| Name | Link |
|---|---|
| Latest commit | f5c2bbce1534a31942b59ae497f27039a60b1ac9 |
| Latest deploy log | https://app.netlify.com/sites/authentik-storybook/deploys/669577e16aecc100087c3ad1 |
| Deploy Preview | https://deploy-preview-10303--authentik-storybook.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for authentik-docs canceled.
| Name | Link |
|---|---|
| Latest commit | f5c2bbce1534a31942b59ae497f27039a60b1ac9 |
| Latest deploy log | https://app.netlify.com/sites/authentik-docs/deploys/669577e1384f5f0008a1afbb |
Tests are not passing currently b/c this changes whether the fields appear in the response when the value is None.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 50.96%. Comparing base (
57399c2) to head (f5c2bbc). Report is 240 commits behind head on main.
:exclamation: There is a different number of reports uploaded between BASE (57399c2) and HEAD (f5c2bbc). Click for more details.
HEAD has 2 uploads less than BASE
Flag BASE (57399c2) HEAD (f5c2bbc) unit 2 0
Additional details and impacted files
@@ Coverage Diff @@
## main #10303 +/- ##
===========================================
- Coverage 92.62% 50.96% -41.66%
===========================================
Files 711 712 +1
Lines 34915 34742 -173
===========================================
- Hits 32339 17706 -14633
- Misses 2576 17036 +14460
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 49.59% <100.00%> (+0.02%) |
:arrow_up: |
| integration | 25.36% <100.00%> (-0.06%) |
:arrow_down: |
| unit | ? |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Is it worth trying to fix the CI errors on this one? I'd like to get an idea of whether this is a good idea before I spend more time on it.