authentik icon indicating copy to clipboard operation
authentik copied to clipboard

web: all aboard the anti-if bus, according to tooling

Open kensternberg-authentik opened this issue 1 year ago β€’ 4 comments

Details

web: all-aboard the anti-if bus, according to tooling

This commit revises a number of bugs eslint has been complaining about for awhile now. This is the lesser of two PRs that will address this issue, and in this case the two biggest problems were inappropriate conditionals (using a switch for a single comparison), unnecessarily named returns, empty returns. This brings our use of conditions in-line with the coding standards we say we want in eslintrc!

  • [X] The code has been formatted (make web)

kensternberg-authentik avatar Jun 25 '24 20:06 kensternberg-authentik

Deploy Preview for authentik-docs ready!

Name Link
Latest commit dd9349c8de077b5256b3e36af49fd30ca5cb6a2f
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/66958408c40c770008390805
Deploy Preview https://deploy-preview-10220--authentik-docs.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 20:06 netlify[bot]

Deploy Preview for authentik-storybook ready!

Name Link
Latest commit dd9349c8de077b5256b3e36af49fd30ca5cb6a2f
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/6695840887c2ae0008b29e7e
Deploy Preview https://deploy-preview-10220--authentik-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Jun 25 '24 20:06 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.50%. Comparing base (c0063c1) to head (dd9349c).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10220      +/-   ##
==========================================
- Coverage   92.62%   92.50%   -0.12%     
==========================================
  Files         714      714              
  Lines       35005    35005              
==========================================
- Hits        32422    32383      -39     
- Misses       2583     2622      +39     
Flag Coverage Ξ”
e2e 48.48% <ΓΈ> (-1.12%) :arrow_down:
integration 25.36% <ΓΈ> (ΓΈ)
unit 90.11% <ΓΈ> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 25 '24 20:06 codecov[bot]

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
global:
    image:
        repository: ghcr.io/goauthentik/dev-server
        tag: gh-ghcr.io/goauthentik/dev-server:gh-dd9349c8de077b5256b3e36af49fd30ca5cb6a2f-arm64

Afterwards, run the upgrade commands from the latest release notes.

github-actions[bot] avatar Jun 25 '24 21:06 github-actions[bot]