authentik
authentik copied to clipboard
website/integrations: Improve discord role sync policies
Details
This changes the websites integration page for discord by modifying two policies.
The new policies are easier to understand and take advantage of group attributes instead of hardcoding values (besides the guild id).
Checklist
- [ ] Local tests pass (
ak test authentik/) - [ ] The code has been formatted (
make lint-fix)
If an API change has been made
- [ ] The API schema has been updated (
make gen-build)
If changes to the frontend have been made
- [ ] The code has been formatted (
make web)
If applicable
- [X] The documentation has been updated
- [ ] The documentation has been formatted (
make website)
Deploy Preview for authentik-docs ready!
| Name | Link |
|---|---|
| Latest commit | 99106610ec179261cea522ba832f43a40983802f |
| Latest deploy log | https://app.netlify.com/sites/authentik-docs/deploys/6697bbbbf1487100074ac901 |
| Deploy Preview | https://deploy-preview-10219--authentik-docs.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Deploy Preview for authentik-storybook ready!
| Name | Link |
|---|---|
| Latest commit | 99106610ec179261cea522ba832f43a40983802f |
| Latest deploy log | https://app.netlify.com/sites/authentik-storybook/deploys/6697bbbb52899800087d71c7 |
| Deploy Preview | https://deploy-preview-10219--authentik-storybook.netlify.app |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 92.61%. Comparing base (
4099341) to head (9910661). Report is 5 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #10219 +/- ##
==========================================
- Coverage 92.62% 92.61% -0.02%
==========================================
Files 714 714
Lines 35008 35008
==========================================
- Hits 32425 32421 -4
- Misses 2583 2587 +4
| Flag | Coverage Ξ | |
|---|---|---|
| e2e | 49.59% <ΓΈ> (-0.01%) |
:arrow_down: |
| integration | 25.37% <ΓΈ> (ΓΈ) |
|
| unit | 90.11% <ΓΈ> (ΓΈ) |
Flags with carried forward coverage won't be shown. Click here to find out more.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I tested these last week with @Keyinator over Discord and they work great!
HI @Keyinator can you run make website or npm run prettier again and repush? That build check is failing. We'll get this merged yet!! :-)
HI @Keyinator can you run
make websiteornpm run prettieragain and repush? That build check is failing. We'll get this merged yet!! :-)
There were indeed fails in my file (fixed now).
However, there is also lint-issues in website/integrations/services/gitlab/index.md. How do we proceed?
There were indeed fails in my file (fixed now). However, there is also lint-issues in
website/integrations/services/gitlab/index.md. How do we proceed?
You can git fetch && git merge origin/main, which should fix the issue in this particular branch. I suppose it was created when we had those fails on main.
I'm sorry we broke the main CI again (we're having GitHub actions issues with this currently). #10524 should fix it. Once that's merged, could you merge main into this branch again?
I'm sorry we broke the main CI again (we're having GitHub actions issues with this currently). #10524 should fix it. Once that's merged, could you merge main into this branch again?
Sure thing :)