authentik icon indicating copy to clipboard operation
authentik copied to clipboard

web: lintpicking

Open kensternberg-authentik opened this issue 1 year ago • 4 comments

Details

While working on other projects, a few small lint issues came up, and their resolutions:

  • Duplicate imports of a web component
    • Duplicates eliminated.
  • A switch statement with a single condition
    • Replaced with a single if expression. If we need further differentiation in the future, we can go back to a switch statement or use a pattern matcher.
  • Empty returns
    • Removed the empty returns, and changed the return type to an inferred Promise<void>, since that is the explict return type implied by a naked return; in an async function.

All of these made eslint complain, so I have edited the code to meet our standards. They are all quite small.

  • [X] The code has been formatted (make web)

kensternberg-authentik avatar Jun 24 '24 19:06 kensternberg-authentik

Deploy Preview for authentik-storybook canceled.

Name Link
Latest commit 67a59268634f3d279863866fd2e5760f7bdf84af
Latest deploy log https://app.netlify.com/sites/authentik-storybook/deploys/668404ded80e1b0008b7ab70

netlify[bot] avatar Jun 24 '24 19:06 netlify[bot]

Deploy Preview for authentik-docs canceled.

Name Link
Latest commit 67a59268634f3d279863866fd2e5760f7bdf84af
Latest deploy log https://app.netlify.com/sites/authentik-docs/deploys/668404de30a5b800083fdb61

netlify[bot] avatar Jun 24 '24 19:06 netlify[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.62%. Comparing base (453f7b8) to head (67a5926).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10212      +/-   ##
==========================================
- Coverage   92.64%   92.62%   -0.03%     
==========================================
  Files         713      713              
  Lines       34978    34978              
==========================================
- Hits        32407    32400       -7     
- Misses       2571     2578       +7     
Flag Coverage Δ
e2e 49.54% <ø> (-0.01%) :arrow_down:
integration 25.38% <ø> (ø)
unit 90.12% <ø> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 24 '24 20:06 codecov[bot]

authentik PR Installation instructions

Instructions for docker-compose

Add the following block to your .env file:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-67a59268634f3d279863866fd2e5760f7bdf84af
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

For arm64, use these values:

AUTHENTIK_IMAGE=ghcr.io/goauthentik/dev-server
AUTHENTIK_TAG=gh-ghcr.io/goauthentik/dev-server:gh-67a59268634f3d279863866fd2e5760f7bdf84af-arm64
AUTHENTIK_OUTPOSTS__CONTAINER_IMAGE_BASE=ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s

Afterwards, run the upgrade commands from the latest release notes.

Instructions for Kubernetes

Add the following block to your values.yml file:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-67a59268634f3d279863866fd2e5760f7bdf84af

For arm64, use these values:

authentik:
    outposts:
        container_image_base: ghcr.io/goauthentik/dev-%(type)s:gh-%(build_hash)s
image:
    repository: ghcr.io/goauthentik/dev-server
    tag: gh-ghcr.io/goauthentik/dev-server:gh-67a59268634f3d279863866fd2e5760f7bdf84af-arm64

Afterwards, run the upgrade commands from the latest release notes.

github-actions[bot] avatar Jun 24 '24 20:06 github-actions[bot]