get-parameter-names icon indicating copy to clipboard operation
get-parameter-names copied to clipboard

Published 20 hours ago • verified publisher icon goatslacker

In spirit of #hacktoberfest, here are all of my changes

Open CaptEmulation opened this issue 7 years ago • 3 comments

  • Support for ES6 class constructors
  • Support for default arguments
  • Fixes a variety of edge cases

However... because we are now doing more parsing...

  • bigger
  • slower

Not having to worry about how functions are written...

  • priceless

Updated from #16 to revert package name.

CaptEmulation avatar Oct 15 '17 03:10 CaptEmulation

Yeah so I guess the tests can only be made to run on newer nodes (w/ support for class) so that would mean node >= 4.x but Travis only covers 0.6 => 0.12 :-(

CaptEmulation avatar Oct 15 '17 03:10 CaptEmulation

Great contribution @CaptEmulation What do you thing about #18 ? Do you think it would be hard to implement ?

Vincz avatar Oct 31 '17 02:10 Vincz

@Vincz Unfortunately no I am not currently supporting destructured arguments with my change. I briefly investigating using a full code parser but found the runtime performance and the package size to be undesirable. The approach here is more low level and does not have a full featured JS parser.

CaptEmulation avatar Oct 31 '17 15:10 CaptEmulation