alt icon indicating copy to clipboard operation
alt copied to clipboard

Published 20 hours ago • verified publisher icon goatslacker

fixed memory leak

Open roths opened this issue 6 years ago • 5 comments

roths avatar May 09 '18 07:05 roths

@goatslacker could you retry the Travis build? It appears to be failing because of something unrelated to the PR.

CrazyPython avatar Jun 19 '18 01:06 CrazyPython

To completely fix this issue you need to patch the function returned from Store.listen as well. +1 though, this was causing a huge memory leak in my app.

matsjoyce avatar Jan 17 '19 12:01 matsjoyce

This fix is really needed for our project. Is there any chance it will get merged, or do we need to just fork and apply the PR to our own fork? I'd rather not have to do that.

jacaetevha avatar Aug 08 '19 14:08 jacaetevha

This PR has been sitting here for over a year already, so I wouldn't wait for it to be merged.

matsjoyce avatar Aug 08 '19 14:08 matsjoyce

i made the fix to the Store.listen in https://github.com/goatslacker/alt/pull/736

davidosomething avatar Nov 27 '19 21:11 davidosomething