Fix header warnings (Part 1)

Open droark opened this issue 7 years ago • 2 comments

Armory has a lot of warnings in its C++ code (not including third-party code, which is typically not touched). Start the process of fixing the warnings, starting with header files (more annoying as they can occur over & over). Warnings fixed include but are not limited to: -Wreorder, -Wunused-parameter, -Wformat-nonliteral, -Wsign-compare, and -Wmaybe-uninitialized.

Nov 15 '18 01:11 droark

Fixed.

Nov 15 '18 09:11 droark

This PR needs to be double checked. This has been rebased after the wave of warning fixes. Some of my fixes are still necessary. This PR may also introduce new warnings (or errors)! I'll check it again later.

Nov 25 '18 22:11 droark