suggestions
suggestions copied to clipboard
goatcorp
Multiple pixel perfect rings
Description
Multiple pixel-perfect-style rings. For example, can use one for hitbox and another to show the distance of ranged abilities. Bonus points for showing the number of enemies in range of a ring. This was originally a request for pixel perfect.
More info
See https://discord.com/channels/581875019861328007/685275026156683280/758867156011450419 for more information.
Original requester: Lynsis#4220
- [x] I checked if this request wasn't already proposed
- [x] I made sure this request follows Dalamud's plugin guidelines
I'm working on a plugin that allows doing that. Currently requested function is implemented, as well as this one https://github.com/goatcorp/suggestions/issues/32 and this https://github.com/goatcorp/suggestions/issues/304 is getting implemented as well, maybe this https://github.com/goatcorp/suggestions/issues/31 too (but for minions one I can't promise 100%) However plugin that I'm making includes functions that will prevent it from getting into main repo, but what I can do is to make limited edition for main repo and put it there. Functions that probably will raise question include:
- Ability to create static waymarks
- Ability to create labels and rings on players (regardless if you target them or not)
Either these functions can stay (but I doubt) or they can be disabled in instances/combat or disabled completely. So basically discussion needed what is allowed and what is not and after figuring it out I'll be ready to send plugin into the main repo for testing. As for pvp, I never really consider it to be honest, but I guess I can just simply disable plugin completely in pvp if that is needed.
Ability to create labels and rings on players (regardless if you target them or not)
would 100% be an advantage in pvp just adding rings to target shouldn't but i would disable it in pvp just in case.
Ability to create static waymarks
elaborate a bit more on this? client side only waymarks or...?
Did you solve the rings showing double rings when viewed up close from underneath? Something to do with the maths I used.
Like thus
Well I think I managed to fix it, maybe not the most proper way but seems like it works
Though I don't even know how valuable are circles if you put camera under that angle, perhaps I can just flat disable rendering them if you put camera too much horizontally and doing it this way also means less math and less load on system
@kalilistic I think you can add in progress to this... or discussion requested? well either way I think I'd be ready to submit it for testing mode after 5.5 fixes and figuring out what is allowed and not?
We set it to just in-progress. Not sure there's any discussion needed since seems within rules (i.e. Pixel Perfect) but someone can correct me if I'm wrong.
Well again, I'm making (made already to some extent) a plugin that does quite a bit more than requested, like, not just rings around you but around other players and enemies, targeted or untargeted, static waymarks with filter by zone, job, there are also plans to implement simple trigger system as well as allowing it to be controlled externally using triggernometry and similar tools, and these functions may not be desired to be present in main repo so what I want to discuss is which functions are actually allowed and which are not since it's not really difficult to make a restricted version.
it's done a while ago, however I don't think it's making into main repo https://github.com/Eternita-S/Splatoon
I can probably move to unclaimed then unless you plan to make a main-repo-friendly version.
The problem is that I never got an answer on what would be main repo friendly version, or rather, which features aren't main repo friendly. According to current rules none actually are against it, clearly there's nothing automatic or any interaction with server, in fact.
So. I may have made made this as a challenge for my first plugin: https://github.com/TBTerra/FF14DistRings though now looking through the pixel perfect plugin, it now also works for this and has a better UI than mine (though mine has custom line styles). so maybe I should go make a pull request for that and close this.
