FFXIVQuickLauncher icon indicating copy to clipboard operation
FFXIVQuickLauncher copied to clipboard

Replace OK & Cancel Button location

Open AdilHindistan opened this issue 2 years ago • 2 comments

Update disclaimer

  • [X] Yes, I have checked and my request is not related to the game updating and plugins not working correctly.

What happened, what did not, what did you want to happen?

On Windows platform, OK and Cancel buttons are placed so that OK is on the left and Cancel is on the right. This, I believe is also a Microsoft recommendation (see here). I do understand that launcher is cross-platform but I am guessing majority of users are Windows.

I am not sure if someone has a strong conviction to leave it as it is but years of habit compels me to click on the left automatically and I have to remind myself it is different for launcher. If it is not too much of a trouble, it would be nice to switch them.

Version

Standard version (Windows, Lutris)

Platform

Windows

AdilHindistan avatar Sep 17 '22 18:09 AdilHindistan

What dialogue/modal is this about? We have many, would need specifics if possible.

goaaats avatar Sep 17 '22 18:09 goaaats

Sorry, let me clarify:

XIV Launcher > Login

  • Use One-time password (checked)
  • use steam service (checked)
  • log in automatically (unchecked)

Please enter your OTP Key, it lists Cancel | OK

I was referring to that order.

AdilHindistan avatar Sep 21 '22 22:09 AdilHindistan

I know this is kind of old but, I am working on a school project and I would like this to be one of my projects. Is it ok for me to use this?

ccanaday1 avatar Oct 11 '22 21:10 ccanaday1

Go ahead! I'll close this issue if you submit a PR.

NotNite avatar Oct 11 '22 22:10 NotNite

Thank you!

ccanaday1 avatar Oct 11 '22 22:10 ccanaday1

Go ahead! I'll close this issue if you submit a PR.

I don't see it in the PR so I'm guessing someone already did this. Thank you for responding quickly! Sorry I am new to GitHub and still learning all I can about it.

ccanaday1 avatar Oct 11 '22 22:10 ccanaday1

I don't see it in the PR so I'm guessing someone already did this.

Someone has not made a PR (Pull Request - used to contribute a code change) for this. You're being invited to make the PR for the feature request.

What @NotNite is saying is that if you make a PR that would handle this issue, she'll close the issue/feature request.

Example: Issue: https://github.com/goatcorp/FFXIVQuickLauncher/issues/1128 PR: https://github.com/goatcorp/FFXIVQuickLauncher/pull/1070

reiichi001 avatar Oct 11 '22 22:10 reiichi001