FFXIVQuickLauncher icon indicating copy to clipboard operation
FFXIVQuickLauncher copied to clipboard

[LINUX][6.2.44-2] Null safety issue on patch days

Open ChristopherJTrent opened this issue 2 years ago • 3 comments

https://github.com/goatcorp/FFXIVQuickLauncher/blob/63f67638d4fb7e0723d928e4ae45ccedd61982a5/src/XIVLauncher.Core/Components/MainPage/MainPage.cs#L266

When attempting to login during maintenance to pre-download patches, the above line throws a System.NullReferenceException presumably related to the LoginResult being passed in. This then short-circuits all of the patch download code, causing a failure to download patches.

This issue should be unrelated to the fact that I have a Steam service account, but it might not be.

ChristopherJTrent avatar Aug 23 '22 06:08 ChristopherJTrent

OK, after digging deeper into the code, it looks like this is "intended" behavior, for lack of a better word. It's very frustrating having such a core feature be broken.

ghost avatar Aug 23 '22 07:08 ghost

It doesn't work, so it's not intended for sure - just means that there hasn't been anyone to implement it in the Linux rewrite. We're pretty busy atm.

goaaats avatar Aug 23 '22 07:08 goaaats

Well, I can't be the one to do it. I don't have any clue how the windows version manages to do it correctly when the linux version fails this spectacularly. I've spent the better part of the last hour looking at the code and I can't for the life of me figure out what's actually happening here on a successful pre-install.

ghost avatar Aug 23 '22 07:08 ghost