goatcorp
add an option to ignore the isSteam Argument
Update disclaimer
- [X] Yes, I have checked and my request is not related to the game updating and plugins not working correctly.
What happened, what did not, what did you want to happen?
I'd like a new setting to allow windows version owners to ignore the 'isSteam' Argument while starting the game so they can use the Steam Free Trial or a copy of the Game to start their windows version. This would allow these users to have the steam overlay, tracking, screenshotting and more.
If I'm allowed I'll also create a pull request to show you my idea of this setting which shouldn't make the project any more complicated while also not affecting the normal steam users.
Edit: While working with Usagi (ウサギ#0001) on Discord we found out that XIVLauncher does not init Steam like the core does. It only inits when Steam is actually checked. The solution to this could be to:
-
A: Accept my PR which adds the special case while not changing/restructuring existing logic: https://github.com/goatcorp/FFXIVQuickLauncher/pull/1070
-
B: Move the Try/Catch Block for Steam Init outside the boolean Check for IsSteam here: https://github.com/goatcorp/FFXIVQuickLauncher/blob/8b54278eac6e4d696d36dbe535a12f8c4905a551/src/XIVLauncher.Common/Game/Launcher.cs#L130
With regards, RenNagasaki
Version
Standard version (Windows, Lutris)
Platform
Windows
