Dalamud icon indicating copy to clipboard operation
Dalamud copied to clipboard

Dev Plugins List Shows Wrong Version

Open PunishedPineapple opened this issue 1 year ago • 4 comments

Dalamud was loaded with a version of a dev plugin enabled (set to load from a custom folder in /xlsettings). The plugin was rebuilt with a new version number, and reloaded through the plugin installer. The installer still shows the old version number. It is loading the new plugin assembly.

It looks like when Dalamud writes out the long-form manifest, it now replaces the correct version number with the old one for some reason.

PunishedPineapple avatar Jul 27 '22 05:07 PunishedPineapple

Couldn't reproduce, the version seems to update properly, can you confirm it is indeed fixed?

Aireil avatar Sep 12 '22 01:09 Aireil

I am still seeing this. I have a dev plugin that I started the game with being set to load at version 1.4.3.2. After incrementing the version to 1.4.3.3 and rebuilding while the game is running with the plugin loaded, I disabled and reenabled the plugin, and it's still showing v1.4.3.2. I confirmed that the assembly file has the expected version, and that the new assembly is being loaded by Dalamud.

I am on the release branch for Dalamud. Should I be retesting this on another branch?

PunishedPineapple avatar Sep 15 '22 06:09 PunishedPineapple

Please try on staging (/xlbranch), I committed a change for this yesterday.

Aireil avatar Sep 15 '22 06:09 Aireil

Actually if you're not hot reloading, it will overwrite the manifest when disabling, I'll check a bit later.

Aireil avatar Sep 15 '22 06:09 Aireil