Dalamud icon indicating copy to clipboard operation
Dalamud copied to clipboard

Installed plugin shows it's internal name in plugin installer instead of public name

Open Limiana opened this issue 2 years ago • 3 comments

Like this TJBR31jgxf

Limiana avatar Jun 02 '22 11:06 Limiana

I'm pretty sure it uses the IDalamudPlugin.Name implementation from the plugin when the plugin is actually loaded. I had this issue with some of mine, and it ended up being that I didn't set that interface member to what I should have. Whether that's ideal behavior for the plugin installer or not, idk.

PunishedPineapple avatar Jun 03 '22 07:06 PunishedPineapple

Isn't IDalamudPlugin.Name - internal plugin's name? Changing it would break updates and so I'd imagine

Limiana avatar Jun 03 '22 07:06 Limiana

I don't think it is, since InternalName in the manifest has to match the assembly name.

Edit: Ok, ya, I just double checked with one of mine that name changed mid-dev, and the Name implementation doesn't have to match InternalName. Wotsit is the same as well.

PunishedPineapple avatar Jun 03 '22 07:06 PunishedPineapple

IDalamudPlugin.Name is basically never used these days. I'm guessing that issue is solved, if not, feel free to reopen it.

Aireil avatar Sep 12 '22 02:09 Aireil