Dalamud
Dalamud copied to clipboard
goatcorp
Plugin Installer Offers Update to Dev Plugin
When using a dev plugin with an older version (actually same version, but installer thinks it's older due to #941 (sorry, I haven't had a good moment to test this again on staging yet :/)), the installer is offering an update to a version from the main repo. This behavior doesn't really make sense imo, especially with the double loading issue when there's a dev plugin and a repo version of the plugin (I'd expect dev plugins to just be ignored entirely when checking for updates):
Pretty sure #941 shouldn't happen on .8, the manifest is reloaded before any (un)loading action. The update notice will only happen until you reopen the installer (assuming your manifest updated properly), could have a last version check there to avoid it.
Concerning the duplicate thing, imo it's mainly a skill issue, if you can't guess that loading the same plugin twice will cause issues, idk what to say.
Could just remove the dev plugin being updated all together, I don't think goat like it either.
Regarding duplicate plugins being loaded, it's not like I can't see it and notice that it's causing issues; it's just an annoyance because when working on a plugin, my previous workflow was that I used the plugins from the main repo unless I was doing work, disabled them and loaded as a dev plugin to do work, sometimes over a couple of days, which meant that Dalamud for some reason then loaded both the dev plugin and the plugin from the repo on the next game start. Now I just use dev plugins only because it was getting to be a not insignificant annoyance. It's a bit better with the delete plugin entirely option in the installer now, but idk, things have just felt pretty wonky and lots of little annoyances since async plugin loading was added.
my previous workflow was that I used the plugins from the main repo unless I was doing work, disabled them and loaded as a dev plugin to do work, sometimes over a couple of days, which meant that Dalamud for some reason then loaded both the dev plugin and the plugin from the repo on the next game start.
I can't reproduce this, but assuming it's indeed an issue, why aren't you deleting the main repo plugin instead of just disabling it? Would avoid having any traces of that version in Dalamud.
I do delete instead of disable now main repo plugins. At one point that wasn't an option in the installer. I still think that it's a problem that it can load duplicate plugins even if it's easier for the user to prevent it from happening now. Regardless, that's not really what this issue is about and there appears to be issue #922 already covering that, so I'm drifting off topic, sorry.
I think it's quite reasonable for both dev and stable plugins to be installed at the same time if one of them is disabled. It might be worth setting this up as an explicitly supported workflow.
