parser-reflection icon indicating copy to clipboard operation
parser-reflection copied to clipboard
verified publisher icon goaop

Add support for UnaryMinus and UnaryPlus expressions

Open marcovtwout opened this issue 1 year ago • 5 comments

Fixes https://github.com/goaop/parser-reflection/issues/140

marcovtwout avatar Jul 11 '24 08:07 marcovtwout

The inspection completed: No new issues

scrutinizer-notifier avatar Jul 11 '24 08:07 scrutinizer-notifier

Hello, nice PR! Could you please also add a test somewhere for this, so it will be tested as well?

lisachenko avatar Jul 12 '24 06:07 lisachenko

@lisachenko I implemented these in a similar fashion as the other resolveExpr functions in that class such as resolveExprBooleanNot(), but didn't find any tests for those in the test suite. I tested them manually, but if you have a suggestion on how to test these I'll write some tests.

marcovtwout avatar Jul 15 '24 08:07 marcovtwout

@lisachenko Since there are no tests yet for the other features and this is still for the dev-version, perhaps merge this and create a seperate issue for adding tests?

marcovtwout avatar Jul 22 '24 10:07 marcovtwout

@lisachenko Could you give an update regarding this issue? It would be great if you could merge this so that the current version of the library becomes useable again.

A-jay98 avatar Sep 23 '24 17:09 A-jay98

thx @marcovtwout 👍

lisachenko avatar Nov 25 '24 15:11 lisachenko