parser-reflection
parser-reflection copied to clipboard
goaop
Migrate to PHP 8
I think you should assure compatibility for both - 7.4 and >=8 versions. It may generate problems when migrating whole environment.
I've updated the branch for compatibility with PHP 7.3 to 8.1.
I noticed the file .github/workflows/phpunit.yml. It appears to run the unit tests under PHP 7.3 and 7.4. Should I also update that file to run the tests under PHP 8.0 and 8.1?
It should be compatible at least with PHP 7.4. (We're using it in production now with that version.) What errors are you seeing? Is there some automation here I can use to see them myself?
(Also, your prior comment said version 7.4 and 8, so I was not targeting 7.3 when I made my latest changes.)
is there an update on this?
I think there will not be any. I've made my forks that support attributes on classes for 8.1
Hello, guys! Do you have a working version of goaop/parser-reflection that supports 8.1? If yes - I can merge your PR here and give you maintainer rights on this repo. @jakublabno WDYT?
I had previously problems with my health, thus decided to stop maintaining projects, but now I can return back to projects, at least in review/maintain mode. And really want to have main project goaop/framework running on PHP8.1
is there an update on this?
I think there will not be any. I've made my forks that support attributes on classes for 8.1
May I see your forked branch?
My proposal is to push existing master branch to the 3.x, take some existing work as main branch and make "master" alias for 4.x + bump minimum version to >=8.0.
Hello, guys! Do you have a working version of goaop/parser-reflection that supports 8.1? If yes - I can merge your PR here and give you maintainer rights on this repo. @jakublabno WDYT?
Yes, I have it working in my private repository fork, I've also made a pr to code generator library to have a possibility proxing classes with attributes.
https://github.com/laminas/laminas-code/pull/145/files
is there an update on this?
I think there will not be any. I've made my forks that support attributes on classes for 8.1
May I see your forked branch?
It's on my gitlab, I'll try to push it public later this week along with laminas code fork
Awaiting @jakublabno, maybe he will be able to open-source/publish his changes as a PR )
Yes, sorry, I remember about that, but recently I had no time to do anything despite my current projects. I'll back to it once I have free time.
Hopefully, will be covered by https://github.com/goaop/parser-reflection/pull/122
Any updates on this? This is blocking us from updating our project to PHP 8.2.
Any updates?
This is blocking me from updating my project tests to PHP 8.2
@lisachenko @jakublabno really need this working on php 8, guys, please help to push this.
Resolved in https://github.com/goaop/parser-reflection/pulls?q=is%3Apr+sort%3Aupdated-desc+is%3Aclosed+author%3Asamsonasik
