open_social icon indicating copy to clipboard operation
open_social copied to clipboard

Issue #3437859: Add new preview popup implementation for the profile preview

Open Agamich-FE opened this issue 10 months ago • 3 comments

Problem

The profile preview popup has an old implementation.

Solution

Should add a new preview popup implementation for the profile preview. PR with new preview popup https://github.com/goalgorilla/open_social/pull/3795.

Issue tracker

https://getopensocial.atlassian.net/browse/PROD-28704 https://www.drupal.org/project/social/issues/3437859

Theme issue tracker

https://www.drupal.org/project/socialbase/issues/3439342

How to test

  • [ ] Enable the social_profile_preview module.
  • [ ] Go to the home page with the stream section.
  • [ ] Hover on the user avatar and you can see preview popup.

Definition of done

Before merge

  • [ ] Code/peer review is completed
  • [ ] All commit messages are clear and clean. If applicable a rebase was performed
  • [ ] All automated tests are green
  • [ ] Functional/manual tests of the acceptance criteria are approved
  • [ ] All acceptance criteria were met
  • [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • [ ] This pull request has all required labels (team/type/priority)
  • [ ] This pull request has a milestone
  • [ ] This pull request has an assignee (if applicable)
  • [ ] Any front end changes are tested on all major browsers
  • [ ] New UI elements, or changes on UI elements are approved by the design team
  • [ ] New features, or feature changes are approved by the product owner

After merge

  • [ ] Code is tested on all branches that it has been cherry-picked
  • [ ] Update hook number might need adjustment, make sure they have the correct order
  • [ ] The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

No need because we do not have any UI changes.

Release notes

Add the new preview popup implementation for the profile preview.

Change Record

Translations

Agamich-FE avatar Apr 03 '24 15:04 Agamich-FE

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:

mergeable[bot] avatar Apr 03 '24 15:04 mergeable[bot]

@ribel, This PR still needs BE work @Macsym2018, please check my changes on the BE code and please clean up extra BE code

Agamich-FE avatar Apr 09 '24 07:04 Agamich-FE

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3842-9svduwht9i5fhe1scyjajl4rewsjhwie.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/660d71eeaa2dcd62df0ea578

open-social-tugboat avatar May 13 '24 06:05 open-social-tugboat

Looks good to me, thanks! But, just for clarification - What is the icon? As I remember this icon renders with amount members of the organization. But here it's not a preview of the organization, but a preview of the profile Screenshot 2024-05-20 at 14 30 53

Kovalskiy266 avatar May 20 '24 11:05 Kovalskiy266

Looks good to me, thanks! But, just for clarification - What is the icon? As I remember this icon renders with amount members of the organization. But here it's not a preview of the organization, but a preview of the profile Screenshot 2024-05-20 at 14 30 53

@ribel, @Kovalskiy266, I've added a fix. Please check on the tugboat env.

Agamich-FE avatar May 20 '24 12:05 Agamich-FE

Good catch @Kovalskiy266! I see it's fixed now, @Agamich-FE 👍 image

ribel avatar May 20 '24 13:05 ribel