open_social icon indicating copy to clipboard operation
open_social copied to clipboard

Issue #3432191: Fix PHPStan warnings from Drupal upgrade

Open vcsvinicius opened this issue 11 months ago • 2 comments

Problem

The last Drupal upgrade start to throw some PHPStan warnings and to continue with the upgrade these warnings was added to be ignored by PHPStan.

The PHPStan ignore added can be check here: https://github.com/goalgorilla/open_social/pull/3806/commits/14894189009...

Solution

Fix these warnings and remove it from PHPStan ignore.

Issue tracker

PROD-28482 #3432191

Theme issue tracker

N/A

How to test

N/A

Definition of done

Before merge

  • [ ] Code/peer review is completed
  • [ ] All commit messages are clear and clean. If applicable a rebase was performed
  • [ ] All automated tests are green
  • [ ] Functional/manual tests of the acceptance criteria are approved
  • [ ] All acceptance criteria were met
  • [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • [ ] This pull request has all required labels (team/type/priority)
  • [ ] This pull request has a milestone
  • [ ] This pull request has an assignee (if applicable)
  • [ ] Any front end changes are tested on all major browsers
  • [ ] New UI elements, or changes on UI elements are approved by the design team
  • [ ] New features, or feature changes are approved by the product owner

After merge

  • [ ] Code is tested on all branches that it has been cherry-picked
  • [ ] Update hook number might need adjustment, make sure they have the correct order
  • [ ] The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

N/A

Release notes

Fixed errors ignored from last Drupal upgrade.

Change Record

N/A

Translations

N/A

vcsvinicius avatar Mar 19 '24 17:03 vcsvinicius