open_social icon indicating copy to clipboard operation
open_social copied to clipboard

Issue #: Uninstall social file private

Open Kingdutch opened this issue 2 years ago • 7 comments

Problem / Solution

The module is no longer needed as of 11.8.0 in https://github.com/goalgorilla/open_social/pull/3306 and we uninstall it in Open Social 12. The idea is that we can then remove the code in Open Social 13.

Issue tracker

Issue to be created

How to test

  • [ ] Open Social should install properly
  • [ ] An Open Social 11 installation should properly uninstall the module
  • [ ] The module may not be uninstalled if another module still depends on it
  • [ ] Installing the module after it being uninstalled throws an error

Definition of done

Before merge

  • [ ] Code/peer review is completed
  • [ ] All commit messages are clear and clean. If applicable a rebase was performed
  • [ ] All automated tests are green
  • [ ] Functional/manual tests of the acceptance criteria are approved
  • [ ] All acceptance criteria were met
  • [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • [ ] This pull request has all required labels (team/type/priority)
  • [ ] This pull request has a milestone
  • [ ] This pull request has an assignee (if applicable)
  • [ ] Any front end changes are tested on all major browsers
  • [ ] New UI elements, or changes on UI elements are approved by the design team
  • [ ] New features, or feature changes are approved by the product owner

After merge

  • [ ] Code is tested on all branches that it has been cherry-picked
  • [ ] Update hook number might need adjustment, make sure they have the correct order
  • [ ] The Drupal.org ticket(s) are updated according to this pull request status

Release notes

The Social File Private module will automatically be uninstalled in all Open Social installations and is now a hidden module. Code will be removed in Open Social 13. If you have any modules that depend on Social File Private you must update them and remove the dependency before upgrading to Open Social 12.0.0

Kingdutch avatar Feb 09 '23 13:02 Kingdutch

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:

mergeable[bot] avatar Feb 09 '23 13:02 mergeable[bot]

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3310-vdwcesxwfwwbhacgds6vghncr7ldqxtx.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/63e4f5c3f8b55eb8b3a4575e

open-social-tugboat avatar Feb 22 '23 00:02 open-social-tugboat

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3310-vdwcesxwfwwbhacgds6vghncr7ldqxtx.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/63e4f5c3f8b55eb8b3a4575e

open-social-tugboat avatar Feb 23 '23 00:02 open-social-tugboat

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3310-vdwcesxwfwwbhacgds6vghncr7ldqxtx.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/63e4f5c3f8b55eb8b3a4575e

open-social-tugboat avatar Feb 24 '23 00:02 open-social-tugboat

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3310-vdwcesxwfwwbhacgds6vghncr7ldqxtx.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/63e4f5c3f8b55eb8b3a4575e

open-social-tugboat avatar Feb 25 '23 00:02 open-social-tugboat

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3310-vdwcesxwfwwbhacgds6vghncr7ldqxtx.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/63e4f5c3f8b55eb8b3a4575e

open-social-tugboat avatar Feb 26 '23 00:02 open-social-tugboat

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3310-vdwcesxwfwwbhacgds6vghncr7ldqxtx.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/63e4f5c3f8b55eb8b3a4575e

open-social-tugboat avatar Feb 27 '23 00:02 open-social-tugboat