open_social
open_social copied to clipboard
Issue #3311354 by vnech: As a LU I want to give or revoke consent to policies when they are not required
Problem
Currently it is possible to set up several data policies for different purposes. Each of these policies is displayed to the user during the signup phase.
Once the choice is made, the user does not have the possibility to change his mind.
In order to make this feature more flexible we want to expose this selection in the user settings.
At this point the user can, at any time, change their initial choice. This can only be done for policies that are not required, when a policy is required it means that the user need to accept it in order to sign up to the platform and can not change his mind without deleting the account
Solution
Add appropriate setting to user settings page where user can give or revoke data policies.
Issue tracker
- https://www.drupal.org/project/social/issues/3311354
- https://getopensocial.atlassian.net/browse/PROD-22054
Theme issue tracker
n/a
How to test
- [x] Enable and configure
Social GDPR
module - [x] Login as LU
- [x] Make sure on page /user/{uid}/edit u can see "Data policies" section and edit non-required consents
Definition of done
Before merge
- [ ] Code/peer review is completed
- [ ] All commit messages are clear and clean. If applicable a rebase was performed
- [ ] All automated tests are green
- [ ] Functional/manual tests of the acceptance criteria are approved
- [ ] All acceptance criteria were met
- [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
- [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
- [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
- [ ] This pull request has all required labels (team/type/priority)
- [ ] This pull request has a milestone
- [ ] This pull request has an assignee (if applicable)
- [ ] Any front end changes are tested on all major browsers
- [ ] New UI elements, or changes on UI elements are approved by the design team
- [ ] New features, or feature changes are approved by the product owner
After merge
- [ ] Code is tested on all branches that it has been cherry-picked
- [ ] Update hook number might need adjustment, make sure they have the correct order
- [ ] The Drupal.org ticket(s) are updated according to this pull request status
Screenshots
A new setting on user settings page:
Release notes
LU can give or revoke non-required consents of policies on own settings page.
Change Record
n/a
Translations
n/a
Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:
Hey @nechai ,
Question about the screenshot you added: was it a conciuos decision to make the card collapsible? We currently only do this in the profile fields which will be removed as part of the profile refactor. The reasoning for this is as follows:
- Collapsible elements on this page don't add a lot of they're not collapsible by default (and they're not currently smart enough to stay collapsed across page reloads if the user desires this).
- The lists are generally short and easy to scroll by if they are expanded.
- On the page we only have collapsible lists within-cards (see the notification card)
~ Alexander
Hi @ribel, regarding your comments:
- I added additional check if data policy exists for fieldset;
- Fixed styles for errors
@nechai I just have only one doubt, other than that everything looks good.
Code here will be declined and will be added to the data policy contrib. Can be found here https://www.drupal.org/project/data_policy/issues/3319392