Issue #3310074 by nkoporec: Remove the self introduction field from profile teaser display

[nkoporec]

Problem

We see the introduction text on the persons overview(search/users) when the new field summary is empty. This is not the desired behavior. If the summary field is empty, there should be no introduction text on the overview page of the people.

Solution

Remove the self-introduction field from the teaser and only display the summary.

Issue tracker

https://www.drupal.org/project/social/issues/3310074

Theme issue tracker

How to test

1. Set up the platform
2. Go to your profile and add an introduction but nothing in the summary field
3. Index the users, so that they show up on the search page
4. Go to search/users
5. Find yourself there and see if the self-introduction text is displayed

Definition of done

Before merge

• [ ] Code/peer review is completed
• [ ] All commit messages are clear and clean. If applicable a rebase was performed
• [ ] All automated tests are green
• [ ] Functional/manual tests of the acceptance criteria are approved
• [ ] All acceptance criteria were met
• [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
• [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• [ ] This pull request has all required labels (team/type/priority)
• [ ] This pull request has a milestone
• [ ] This pull request has an assignee (if applicable)
• [ ] Any front end changes are tested on all major browsers
• [ ] New UI elements, or changes on UI elements are approved by the design team
• [ ] New features, or feature changes are approved by the product owner

After merge

• [ ] Code is tested on all branches that it has been cherry-picked
• [ ] Update hook number might need adjustment, make sure they have the correct order
• [ ] The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

https://monosnap.com/file/8PgeCXXqmA3PexdZRM1ravow86ekCf

Release notes

[Required if new feature, and if applicable] A short summary of the changes that were made that can be included in release notes.

Change Record

[Required if applicable] If this Pull Request changes the way that developers should do things or introduces a new API for developers then a change record to document this is needed. Please provide a draft for a change record or a link to an unpublished change record below. Existing change records can be consulted as example. Please provide a draft for a change record or a link to an unpublished change record below. Existing change records can be consulted as example.

Translations

[Optional]Translatable strings are always extracted from the latest development branch. To ensure translations remain available for platforms running older versions of Open Social the original string should be added to translations.php when it's changed or removed.

• [ ] Changed or removed source strings are added to the translations.php file.

[mergeable[bot]]

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:

[navneet0693]

@nkoporec I just gave quick look to the PR, I see that we are making the field field_profile_self_introduction hidden in teaser. But does that achieve our goal? What happens when both summary and introduction field are filled? Or, what happens when the summary is added but no introduction is added?

I request you to add the descriptions of the above requested behaviour in PR body, probably like an FAQ with screenshots of different scenarios.

[nkoporec]

I can't seem to reproduce this anymore, so it seems it has been fixed in recent versions. Closing the PR.