Issue #3304774 by vnech: Reordering categories in "Content Tags"

[nechai]

Problem

Currently site manager can't reorder categories (parent terms) in "Content tags" vocabulary. Reordering categories can be useful for some business needs - underline some prioritised tags etc.

Solution

Add a new "Categories reordering" setting item to "Tag settings".

Issue tracker

• https://www.drupal.org/project/social/issues/3304774
• https://getopensocial.atlassian.net/browse/PROD-21848

Theme issue tracker

N/A

How to test

• [x] Login as SM
• [x] Make sure you have at lease two categories in Content tags vocabulary (admin/structure/taxonomy/manage/social_tagging/overview)
• [x] On /admin/config/opensocial/tagging-settings:
  • [x] Enable tagging for Topic in Type configuration section
  • [x] Change terms order in Categories ordering section
• [x] Visit /node/add/topic and make sure the categories in Tags section displaying in correct order

Definition of done

Before merge

• [ ] Code/peer review is completed
• [ ] All commit messages are clear and clean. If applicable a rebase was performed
• [ ] All automated tests are green
• [ ] Functional/manual tests of the acceptance criteria are approved
• [ ] All acceptance criteria were met
• [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
• [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
• [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
• [ ] This pull request has all required labels (team/type/priority)
• [ ] This pull request has a milestone
• [ ] This pull request has an assignee (if applicable)
• [ ] Any front end changes are tested on all major browsers
• [ ] New UI elements, or changes on UI elements are approved by the design team
• [ ] New features, or feature changes are approved by the product owner

After merge

• [ ] Code is tested on all branches that it has been cherry-picked
• [ ] Update hook number might need adjustment, make sure they have the correct order
• [ ] The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

A new setting in "Tag settings":

Release notes

Add an ability to reorder categories in "Content tag" vocabulary.

Change Record

N/A

Translations

N/A

[open-social-tugboat]

Tugboat has finished building the preview for this pull request!

Link:

• https://pr3073-lgome9gmfho4lvc9l6obgoicma4ki7tm.tugboatqa.com

Dashboard:

• https://dashboard.tugboatqa.com/62ff8998a476796b1ca81a12

[ribel]

Hi @nechai, I noticed new PHPStan error here. Could you check it?

[navneet0693]

@nechai PHPStan checks are failing. Please work on it.

[ribel]

@nechai Please update with the main branch and make sure all tests pass.

[ribel]

Hi @navneet0693, Now it's ready for the review again.

[nkoporec]

:cherries: picked to 11.6.x and 11.5.x