open_social icon indicating copy to clipboard operation
open_social copied to clipboard

Issue #3304336 by zanvidmar: Tile teaser's content on resources library page on mobile is not visible

Open zanvidmar opened this issue 2 years ago • 3 comments

Problem

Tile teasers content on resources library page on mobile is not visible

Solution

Change css

Issue tracker

3304336

Theme issue tracker

N/A

How to test

  • [ ] Create resources library content and go to /search/resources
  • [ ] Set display size to 599px width or lower and you will see that body content of teasers is missing (see attachments).
  • [ ] The teaser's content is empty
  • [ ] The expected result is attained when repeating the steps with this fix applied.

Definition of done

Before merge

  • [ ] Code/peer review is completed
  • [ ] All commit messages are clear and clean. If applicable a rebase was performed
  • [ ] All automated tests are green
  • [ ] Functional/manual tests of the acceptance criteria are approved
  • [ ] All acceptance criteria were met
  • [ ] New features or changes to existing features are covered by tests, either unit (preferably) or behat
  • [ ] Update path is tested. New hook_updates should respect update order, right naming convention and consider hook_post_update code
  • [ ] Module can be safely uninstalled. Update/implement hook_uninstall and make sure that removed configuration or dependencies are removed/uninstalled
  • [ ] This pull request has all required labels (team/type/priority)
  • [ ] This pull request has a milestone
  • [ ] This pull request has an assignee (if applicable)
  • [ ] Any front end changes are tested on all major browsers
  • [ ] New UI elements, or changes on UI elements are approved by the design team
  • [ ] New features, or feature changes are approved by the product owner

After merge

  • [ ] Code is tested on all branches that it has been cherry-picked
  • [ ] Update hook number might need adjustment, make sure they have the correct order
  • [ ] The Drupal.org ticket(s) are updated according to this pull request status

Screenshots

Release notes

N/A

Change Record

N/A

Translations

N/A

zanvidmar avatar Aug 17 '22 16:08 zanvidmar

Thanks for contributing towards Open Social! A maintainer from the @goalgorilla/maintainers group might not review all changes from all teams/contributors. Please don't be discouraged if it takes a while. In the meantime, we have some automated checks running and it might be that you will see our comments with some tips or requests to speed up the review process. :blush:

mergeable[bot] avatar Aug 17 '22 16:08 mergeable[bot]

Tugboat has finished building the preview for this pull request!

Link:

  • https://pr3072-3xh3u54tsf2sk2yrdx2neqs9zcgabq5d.tugboatqa.com

Dashboard:

  • https://dashboard.tugboatqa.com/62fd14ee19770b441acca777

open-social-tugboat avatar Aug 17 '22 16:08 open-social-tugboat

Can reviewer please check if updated css target any other occurrence beside the one mentioned and check if this does not break anything else. Thank you.

zanvidmar avatar Aug 17 '22 16:08 zanvidmar

@zanvidmar The changes looks good, can you add a milestone and also update the PR title and description ? The resource library is a paid extension and we should not mention it in the open source community repository, just update it and find a way to test this bug without the paid extension enabled.

Also add the release notes.

nkoporec avatar Aug 22 '22 11:08 nkoporec

Based on further investigation the provided fix might not be correct. Further analysis is required as there are some design inconsistencies in first place.

zanvidmar avatar Aug 25 '22 07:08 zanvidmar

I am closing this PR as it will be handled differently. Here is the new MR: https://git.drupalcode.org/project/socialbase/-/merge_requests/146

zanvidmar avatar Aug 29 '22 07:08 zanvidmar